Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2821

Merged
merged 9 commits into from
Sep 5, 2024
Merged

[Release] Stage to Main #2821

merged 9 commits into from
Sep 5, 2024

Conversation

milo-pr-merge[bot]
Copy link
Contributor

@milo-pr-merge milo-pr-merge bot commented Sep 3, 2024 •
edited
Loading

Reverted

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

@bandana147
Checking if Ims is already initialized before loading it (#2802)
318f2e8 
* Checking if Ims is already initialized

* Moving the check to global navigation

* Lint fix
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Sep 3, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 3, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 3, 2024 •
edited
Loading

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@mokimo
Fix video CLS netting +10 lighthouse points (#2750)
8df386c 
* MWPW-155412: Fix video CLS netting +10 lighthouse points (#2724)

* fix cls by adding the videoEl without a source

* adapt the video hover and in view port play

* Remove no-lazy and return earlier

* Fix linting issue

* Consolidate duplicated logic

* Move functions into the init function

* Move root margin and use optional chaining

* Only query for the videoEl once

* Add default hash at in the right spot

* Fix the figure/video interaction

* Remove unused export statement

* Keep the previous defaults
@mokimo mokimo requested a review from a team as a code owner September 3, 2024 18:09
@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.15686% with 16 lines in your changes missing coverage. Please review.

Project coverage is 95.89%. Comparing base (7216452) to head (264c998).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
libs/blocks/youtube/youtube.js 85.39% 13 Missing ⚠️
libs/blocks/vimeo/vimeo.js 95.83% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2821      +/-   ##
==========================================
- Coverage   95.89%   95.89%   -0.01%     
==========================================
  Files         173      173              
  Lines       46150    46316     +166     
==========================================
+ Hits        44256    44415     +159     
- Misses       1894     1901       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dli3
Dli3 requested changes Sep 3, 2024
View reviewed changes
Copy link

@Dli3 Dli3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mokimo We're still seeing the video controls displaying and autoplay issue on bacom. Reproducible on all browsers.

Reproducible on:

image

@JackySun9 JackySun9 removed the run-caas label Sep 3, 2024
@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label Sep 4, 2024
@JackySun9 JackySun9 added run-nala-on-caas and removed run-nala Run Nala Test Automation against PR run-nala-on-caas labels Sep 4, 2024
@JackySun9 JackySun9 added the @caas label Sep 4, 2024
@JackySun9 JackySun9 added the @faas Run FaaS Block Tests Nala label Sep 4, 2024
@aem-code-sync aem-code-sync bot requested a deployment to stage September 4, 2024 19:34 Queued
@skumar09 skumar09 added run-nala Run Nala Test Automation against PR and removed run-nala Run Nala Test Automation against PR labels Sep 5, 2024
@JackySun9 JackySun9 added run-nala Run Nala Test Automation against PR and removed run-nala Run Nala Test Automation against PR labels Sep 5, 2024
@milo-pr-merge milo-pr-merge bot merged commit 95fb526 into main Sep 5, 2024
43 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bandana147 bandana147 bandana147 approved these changes

@Dli3 Dli3 Dli3 approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@Roycethan Roycethan Roycethan approved these changes

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@sonawanesnehal3 sonawanesnehal3 sonawanesnehal3 approved these changes

@salonijain3 salonijain3 Awaiting requested review from salonijain3 salonijain3 is a code owner

@sharmrj sharmrj Awaiting requested review from sharmrj sharmrj is a code owner

@nishantka nishantka Awaiting requested review from nishantka nishantka is a code owner

@Deva309 Deva309 Awaiting requested review from Deva309 Deva309 is a code owner

Assignees
No one assigned
Labels
BAcom SOT 👌 CC SOT 👌 Homepage SOT 👌 MIQ SOT👌 run-nala Run Nala Test Automation against PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.