[Release] Stage to Main #2811
Merged
[Release] Stage to Main #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![milo-pr-merge[bot]](https://avatars.githubusercontent.com/u/95242840?s=60&v=4){kind=small}
…L instead of just fragments (#2683) * getSelectedElement - V2 * getSelectedElement - V2 * getSelectedElement - V2 * getSelectedElement - V2 * getSelectedElement - V2 * added test coverage for action * cleanup * added comments * comments * comments * fixes erroring but still has failure * rooEl fix * fixed tests * added modifier * eslint * lint * removed reduncant try catch * Add target analytics for update action * removed test-results and added to .gitignore * reverted a deletion of a prependtosection validation code * removed comments * updated validation for appendtosdection * removed comments and eslint escapes * change modifier to an array that is not a separate column * add highight for update * add timeout to merch-card highlight * remove setTimeout and move preview.js call from loadPostLCP to loadDeferred * update unit test * remove update to git ignore * add temp console message for easy QA * MWPW-155566 [MEP] Changing from a new action to just expanding power of existing actions (#2764) * stash * use replace instead of update, allow html for create commands, update simplified selectors * streamline * remove export on MILO_BLOCKS * change prependToSection and appendToSection to just prepend and append * remove unused function param * change from includes to === * remove use of .parentElement * move spoof param test so you can reload the other tests * account for number used after dot notation * add test to insertbefore and insert after href * more coverage * more coverage * hopefully final coverage * remove console * rename checkSelectorType to getSelectorType * move parts of createContent into sub functions * small big fix * update modifySelectorTerm function per suggestion * update modifyNonFragmentSelector per suggestion * update to getSelectedElement * change equal to not equal * fix end number update * codecov * no longer require fragments be in URL for fragments because of gnav * call getModifiers in modifyNonFragmentSelector instead * require space before first flag * update unit tests to need space before flags * handle adding flags to fragment selectors * revert for demo * put back * remove utils update so it does not conflict --------- Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: vgoodric <[email protected]> Co-authored-by: markpadbe <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]>
…MD (#2765) * Add charlimit for headers analytics * Fix header for integer value only * Update libs/martech/attributes.js set header length to false for clarity Co-authored-by: Vivian A Goodrich <[email protected]> * Add tests * Refacter str null check per suggestion * Fix test coverage --------- Co-authored-by: Vivian A Goodrich <[email protected]>
* MWPW-145727: add configurator changes for alt cta on live events * MWPW-14572: get the alt cta from secondaryCTA so it can be localized by caas * lint * left something in * left something in * unit tests * unit tests * MWPW-145727: unit tests * MWPW-145727: unit tests * MWPW-145727: unit tests * MWPW-145727: unit tests * unit tests hopefully * ok finally the unit tests probably * ok this will be the one * variable name * config hash test --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Sheridan Sunier <[email protected]>
* add sitemap * remove pandora wcs client * remove obsolete dependencies * fix request&settings test * remove domainSwitch * fix tests * update deps * fix review comment * use usual error message * fix language param * commit packag-lock * bring back transitive dependencies * bring back www.stage.adobe.com * omit cookies for wcs requests * revert special logic for stage
* hero bugz updates * added wrapInnerHTMLInPTag for single line entries * changed order to wrapInnerinP so it happens before decorateButtons * PR feedback * PR feedback - minor logic fix for potential null value * minor fix, missing scope for flex dir col for .bg-bottom-tablet * missing selector for bg-bottom-tablet btm padding * Fixed scope so row-lockup also gets iconography.css * PR feedback, shorten some code logic * await loadIconography
* gnav dark theme init * Dark gnav icon changes * Dark gnav changes * add theme in standalone gnav config * allow 2 logo for dark mode * UTs for gnav dark theme * UTs for gnav dark theme * Dark gnav color changes * gnav dark mode refactor css * gnav dark mode refactor css * load darknav after base to override variables * update darknav promo css * lightmode promobar link color * update region nav link color * update nav background color for darkmode * fix outline for windows * update darknav css
…red (#2770) * move call for preview from loadPostLCP to loadDeferred * change function name to getSelectorType * revert
#2772) * branch banner ecid * review changes * passing ecid value --------- Co-authored-by: Drashti Modasara <[email protected]>
* update button decorator to handle custom classes * add dash character to regex * add coverage * add safeguard for href-less buttons * account for modals * Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux)" (#2777) Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux) (#2767)" This reverts commit 88cb101. * add modal coverage * Revert "Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux)" (#2777)" This reverts commit b1a3948.
* adjustment to colors for better contrast * aria-label for carousel arrows * css clean up Resolves: [MWPW-156126](https://jira.corp.adobe.com/browse/MWPW-156126)
* nala initial commit * gitignore * updated the tests * update to the packages * updating util file * remove new line * update base-reporter.js * update geo pom * update nala run * update git ignore * fixing eslint errors * eslint fixes --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]> Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
Eagerly import lit from merch-card block
|
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
milo-pr-merge
bot
requested review from
colloyd,
fullcolorcoder,
JackySun9,
a team,
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309,
sonawanesnehal3 and
chrischrischris
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Unexpected console statement.
milo/libs/navigation/navigation.js
Line 43 in fc58707
|
|
||
| // Test 0 : Accordion Container | ||
| test(`${features[0].name},${features[0].tags}`, async ({ page, baseURL }) => { | ||
| console.info(`[Test Page]: ${baseURL}${features[0].path}${miloLibs}`); |
There was a problem hiding this comment.
Unexpected console statement.
|
|
||
| // Test 1 : Accordion (seo) | ||
| test(`${features[1].name},${features[1].tags}`, async ({ page, baseURL }) => { | ||
| console.info(`[Test Page]: ${baseURL}${features[1].path}${miloLibs}`); |
There was a problem hiding this comment.
Unexpected console statement.
| return scriptElement ? scriptElement.textContent : null; | ||
| }); | ||
| expect(scriptContent).toBeTruthy(); | ||
| console.log('[SEO Script content]:', scriptContent); |
There was a problem hiding this comment.
Unexpected console statement.
|
|
||
| // Test 2 : Accordion (quiet, max-width-12-desktop-large) | ||
| test(`${features[2].name},${features[2].tags}`, async ({ page, baseURL }) => { | ||
| console.info(`[Test Page]: ${baseURL}${features[2].path}${miloLibs}`); |
There was a problem hiding this comment.
Unexpected console statement.
|
|
||
| // Test 3 : Accordion seo editorial | ||
| test(`${features[3].name},${features[3].tags}`, async ({ page, baseURL }) => { | ||
| console.info(`[Test Page]: ${baseURL}${features[3].path}${miloLibs}`); |
There was a problem hiding this comment.
Unexpected console statement.
* fix(a11y): added a11y two header tables * fix(heading): fixing the first row as columnheader * fix: heading more describable * fix(table): dynamic id added * fix: unique id for header body,pricing tag * chore: code opt * chore: eslint fix * fix(tab-focus): fixed key event in expand section * fix: review changes
… are used in non EN page (#2780) * Initial checkin - Working state. * Optimization. Good State. * Semi-colon fix. * Linting fixes. * Unit test file creation. * Placeholders update/fix. * Fixed US data values. * Unit testing WIP. * fix unit test * unit test working * add before each * fix linter issue of using same name above * update processTrackingLabels * add coverage to attributes.js unit test * Unit test updates. --------- Co-authored-by: vgoodric <[email protected]>
mokimo
added a commit
to mokimo/milo
that referenced
this pull request
Sep 3, 2024
[Release] Stage to Main adobecom#2811
Roycethan
approved these changes
Sep 3, 2024
Roycethan
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
JackySun9
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
sigadamvenkata
approved these changes
Sep 3, 2024
sigadamvenkata
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
JackySun9
approved these changes
Sep 3, 2024
JackySun9
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
Dli3
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: