-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Stage to Main #2775
[Release] Stage to Main #2775
Conversation
* MWPW-151936 Aside Tiger Team Enhancements * fix standard tests * update tests * simplify icon area * set approved desktop column spans * css updates based on feedback * account for notifications --------- Co-authored-by: Megan Thomas <[email protected]>
* added payment-details slot and changed badge width * fixed duplicated callout content * fixed eslint * added libs/deps/mas to paths-ignore in codeql * replaced payment-details slot
* changed the swc version to 0.46.0 * added polyfills import * corrected import * corrected import * added warning about polyfills in readme * fixed typos and changed imports * corrected import * brought back the loadScript * correction for the readme
* [MWPW-152305][MWPW-152339] Table background and checkmark treatment * MWPW-151826 - Table header and cell alignment (#2516) * header buttons vertical alignment matches across all headers * content cell horizontal alignment match what is set in headers defaulting to center * header style updates, including: color, font-size, etc. Resolves: [MWPW-151826](https://jira.corp.adobe.com/browse/MWPW-151826) Resolves: [MWPW-152313](https://jira.corp.adobe.com/browse/MWPW-152313) * [MWPW-153727] Remove extra border radius from table highlight (#2537) * [MWPW-153881] Table section not initially expanding on mobile (#2539) * [MWPW-153848][MWPW-153860] Table highlight, sticky, radius improvements (#2562) * [MWPW-153848][MWPW-153860] Table highlight, sticky, radius improvements * Avoid table exceeding viewport * MWPW-152336 - Table tooltip fixes (#2623) * MWPW-152336 - Table tooltip fixes * force tooltip positioning for row-title in mobile and rtl scenarios so they are always fully visible Resolves: [MWPW-152336](https://jira.corp.adobe.com/browse/MWPW-152336) * Update libs/blocks/table/table.css Co-authored-by: Rares Munteanu <[email protected]> * Update libs/blocks/table/table.css Co-authored-by: Rares Munteanu <[email protected]> * Update libs/blocks/table/table.css Co-authored-by: Rares Munteanu <[email protected]> * PR feedback to reduce verbose selectors --------- Co-authored-by: Rares Munteanu <[email protected]> * MWPW-153609 - Unit test fixes for table * Set hovering test to it targets an element that has height * Adjusted placement of the fix for MWPW-153881 to ensure that filters are added when it is called Resolves: [MWPW-153609](https://jira.corp.adobe.com/browse/MWPW-153609) * [MWPW-153267] Expand table to parent grid size (#2637) * [MWPW-153894] Addressing overflowing table content on mobile (#2672) * [MWPW-156638] Table row header items wrap (#2747) * [MWPW-156925] Table - design parity tweaks after Consonant feedback (#2760) --------- Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Cody Lloyd <[email protected]>
… out (#2754) * MWPW-156898 [MEP] Add setting to use XLG segments in MEP while logged out * add 2 segments * unit test * unit test update
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2775 +/- ##
==========================================
- Coverage 95.91% 95.89% -0.02%
==========================================
Files 173 173
Lines 45831 45889 +58
==========================================
+ Hits 43958 44005 +47
- Misses 1873 1884 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're seeing an issue with the notification aside variant on bacom. The text no longer wraps on mobile and tablet. It now overlaps with the text on the same line.
Also, looks like the size of the image on the left also got updated?
Reproducible on https://main--bacom--adobecom.hlx.live/products/genstudio?milolibs=stage .
Not reproducible on https://main--bacom--adobecom.hlx.live/products/genstudio .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes for now while sorting out issues with the table. @sigadamvenkata make sure you 'request changes' instead of applying the do not merge label, that one doesn't do anything for the automated process
above issue has been identified as content issues and we are good to go. below tickets will be fallowed up with GWP team |
From my perspective the code is good to go on prod, with the note that GWP will need to fix DOTCOM-133521 for stage (not blocker) and eng need to fix existing issue on prod in the future MWPW-157334 (not blocker) CC: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blockers resolved.
Reverts
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: