Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2775

Merged
merged 8 commits into from
Sep 2, 2024
Merged

[Release] Stage to Main #2775

merged 8 commits into from
Sep 2, 2024

Conversation

elan-tbx and others added 5 commits August 21, 2024 18:20
* MWPW-151936 Aside Tiger Team Enhancements

* fix standard tests

* update tests

* simplify icon area

* set approved desktop column spans

* css updates based on feedback

* account for notifications

---------

Co-authored-by: Megan Thomas <[email protected]>
* added payment-details slot and changed badge width

* fixed duplicated callout content

* fixed eslint

* added libs/deps/mas to paths-ignore in codeql

* replaced payment-details slot
* changed the swc version to 0.46.0

* added polyfills import

* corrected import

* corrected import

* added warning about polyfills in readme

* fixed typos and changed imports

* corrected import

* brought back the loadScript

* correction for the readme
* [MWPW-152305][MWPW-152339] Table background and checkmark treatment

* MWPW-151826 - Table header and cell alignment (#2516)

* header buttons vertical alignment matches across all headers
* content cell horizontal alignment match what is set in headers defaulting to center
* header style updates, including: color, font-size, etc.

Resolves: [MWPW-151826](https://jira.corp.adobe.com/browse/MWPW-151826)
Resolves: [MWPW-152313](https://jira.corp.adobe.com/browse/MWPW-152313)

* [MWPW-153727] Remove extra border radius from table highlight (#2537)

* [MWPW-153881] Table section not initially expanding on mobile (#2539)

* [MWPW-153848][MWPW-153860] Table highlight, sticky, radius improvements (#2562)

* [MWPW-153848][MWPW-153860] Table highlight, sticky, radius improvements

* Avoid table exceeding viewport

* MWPW-152336 - Table tooltip fixes (#2623)

* MWPW-152336 - Table tooltip fixes

* force tooltip positioning for row-title in mobile and rtl scenarios so they are always fully visible

Resolves: [MWPW-152336](https://jira.corp.adobe.com/browse/MWPW-152336)

* Update libs/blocks/table/table.css

Co-authored-by: Rares Munteanu <[email protected]>

* Update libs/blocks/table/table.css

Co-authored-by: Rares Munteanu <[email protected]>

* Update libs/blocks/table/table.css

Co-authored-by: Rares Munteanu <[email protected]>

* PR feedback to reduce verbose selectors

---------

Co-authored-by: Rares Munteanu <[email protected]>

* MWPW-153609 - Unit test fixes for table

* Set hovering test to it targets an element that has height
* Adjusted placement of the fix for MWPW-153881 to ensure that filters are added when it is called

Resolves: [MWPW-153609](https://jira.corp.adobe.com/browse/MWPW-153609)

* [MWPW-153267] Expand table to parent grid size (#2637)

* [MWPW-153894] Addressing overflowing table content on mobile (#2672)

* [MWPW-156638] Table row header items wrap (#2747)

* [MWPW-156925] Table - design parity tweaks after Consonant feedback (#2760)

---------

Co-authored-by: Cody Lloyd <[email protected]>
Co-authored-by: Cody Lloyd <[email protected]>
… out (#2754)

* MWPW-156898 [MEP] Add setting to use XLG segments in MEP while logged out

* add 2 segments

* unit test

* unit test update
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Aug 21, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested review from a team and Sartxi as code owners August 21, 2024 18:20
Copy link
Contributor

aem-code-sync bot commented Aug 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Aug 21, 2024

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/dialog.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/divider.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/icon.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/icons/asterisk.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/icons/checkmark.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/icons/chevron.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/icons/corner-triangle.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/icons/cross.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/icons/dash.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/link.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/menu.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/overlay.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/picker.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/popover.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/progress-circle.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/reactive-controllers.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/search.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/shared.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/sidenav.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/tabs.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/textfield.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/theme.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/toast.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/tooltip.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/tray.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/dist/underlay.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/0ae86a39b0b3b76fdd9eadee1114d7a652b061d0/libs/features/spectrum-web-components/src/overlay.js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (2abe70f) to head (6012fcb).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2775      +/-   ##
==========================================
- Coverage   95.91%   95.89%   -0.02%     
==========================================
  Files         173      173              
  Lines       45831    45889      +58     
==========================================
+ Hits        43958    44005      +47     
- Misses       1873     1884      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Dli3 Dli3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're seeing an issue with the notification aside variant on bacom. The text no longer wraps on mobile and tablet. It now overlaps with the text on the same line.

Also, looks like the size of the image on the left also got updated?

Reproducible on https://main--bacom--adobecom.hlx.live/products/genstudio?milolibs=stage .
Not reproducible on https://main--bacom--adobecom.hlx.live/products/genstudio .

image

cc @elan-tbx @JasonHowellSlavin @Brandon32

@sigadamvenkata sigadamvenkata added the do not merge PR should not be merged yet label Sep 2, 2024
@sigadamvenkata
Copy link

this PR need re-verification for all locales. seen the stage issue below for mobiles in the JP locale across IOS/Andriod devices
image

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for now while sorting out issues with the table. @sigadamvenkata make sure you 'request changes' instead of applying the do not merge label, that one doesn't do anything for the automated process

@sigadamvenkata sigadamvenkata removed the do not merge PR should not be merged yet label Sep 2, 2024
@sigadamvenkata
Copy link

above issue has been identified as content issues and we are good to go. below tickets will be fallowed up with GWP team
https://jira.corp.adobe.com/browse/DOTCOM-133521

@SilviuLCF
Copy link

From my perspective the code is good to go on prod, with the note that GWP will need to fix DOTCOM-133521 for stage (not blocker) and eng need to fix existing issue on prod in the future MWPW-157334 (not blocker) CC:

CC: @narcis-radu @sigadamvenkata @mokimo @overmyheadandbody

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blockers resolved.

@milo-pr-merge milo-pr-merge bot merged commit eeddca4 into main Sep 2, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.