Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2766

Merged
merged 4 commits into from
Aug 21, 2024
Merged

[Release] Stage to Main #2766

merged 4 commits into from
Aug 21, 2024

Conversation

Axelcureno and others added 2 commits August 20, 2024 18:10
* Removal of merch-card-all dep

* improved dep imports

* Update mas.js

* Update mas.js

* removed sequential imports

* pr feedback

* fixes
#2703)

* changes in utils

* changes in utils view port

* changes in view-port sizes

* unit test cases

* viewport for desktop

* viewport for desktop

* shifting the logic to decorate.js

* lint error

* lint error

* unit tests

* unit tests

* unit tests

* unit tests

* unit tests

* unit tests

---------

Co-authored-by: Suhani <[email protected]>
Co-authored-by: Suhani <[email protected]>
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Aug 20, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner August 20, 2024 18:10
Copy link
Contributor

aem-code-sync bot commented Aug 20, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Aug 20, 2024

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

…se (#2751)

* Prevent link breaks before 'ー U+2013', '〜 U+301C'

* Refactor CSS for Japanese line-break
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (dad8c45) to head (2abe70f).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2766      +/-   ##
==========================================
+ Coverage   95.88%   95.91%   +0.02%     
==========================================
  Files         173      173              
  Lines       45799    45831      +32     
==========================================
+ Hits        43914    43958      +44     
+ Misses       1885     1873      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* MWPW-155057: [Merch cards] Add ability for authors to add "starting at"

Preview: https://main--cc--adobecom.hlx.page/drafts/axel/stories/mwpw-155057-starting-at?milolibs=MWPW-155057--milo--adobecom

* improved impl

* unit tests

* Update merch-card.js

* Update merch-card.test.js

* Update segment-card.html

* unit test

* Update merch-card.js

* Update merch-card.js

* Update merch-card.test.js

* Update merch-card.js

* Update merch-card.js

* Update merch-card.js

* Update merch-card.js

* Update merch-card.js

* Update merch-card.js

* unit test and pr feedback

* conflicts resolved
@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label Aug 21, 2024
@milo-pr-merge milo-pr-merge bot merged commit c06c15d into main Aug 21, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants