[Release] Stage to Main #2756
[Release] Stage to Main #2756
Conversation
![milo-pr-merge[bot]](https://avatars.githubusercontent.com/u/95242840?s=60&v=4){kind=small}
* MWPW-151936 Aside Tiger Team Enhancements * fix standard tests * update tests * simplify icon area * set approved desktop column spans * css updates based on feedback --------- Co-authored-by: Elan Bartholomew <[email protected]>
* various adjustments based on design review * accounting for ribbon edge case * update tests to an async context * add lockup to test mock * improve test coverage * improve logic readability * updates based on PR feedback * remove .container selector * change full-width to max-width-12-desktop
MWPW-xxxx - quiz option contrast fixes * adjusts the blue text color of selected option cards so they have enough accessible color contrast Resolves: [MWPW-147759](https://jira.corp.adobe.com/browse/MWPW-147759) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off
|
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
milo-pr-merge
bot
requested review from
colloyd,
sabyamon,
fullcolorcoder,
JackySun9,
elan-tbx,
Sartxi,
ryanmparrish and
a team
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 173 173
Lines 45771 45799 +28
=======================================
+ Hits 43886 43914 +28
Misses 1885 1885 ☔ View full report in Codecov by Sentry. |
…#2743) added z-index to sp-action-menu
* MWPW-156262 use standard tab browsing in collection - set specific card keydown handler a property of a merch-card, true by default, - in case of contained in a collection, above property is set to false, and tabindex is added in same order than collection * MWPW-156262 removing arrow browsing altogether * MWPW-156262 remove key unit test, - no more custom logic to test, - removing window.width based test skips that was avoiding collection tests * rebuild deps --------- Co-authored-by: Mariia Lukianets <[email protected]>
* test for perf tiger teams * MWPW-155687 * removing old
add no borders option
There was a problem hiding this comment.
We're seeing an issue with the text wrapping on the aside notification block on bacom.
Observe where it wraps on business.stage.adobe.com, but on milo stage it wraps much later.
Was this intended @elan-tbx ?
Reproducible on https://business.stage.adobe.com/?milolibs=stage .
Not reproducible on https://business.stage.adobe.com/ .
|
@Dli3 Apologies for my previous comment -- I had mixed up which page was showing the issue and spoke too soon. This appears to be specific to the deprecated |
Roycethan
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
|
@Dli3 can you retest? |
|
We are providing approval for PR. but just wanted to mention an issue we notice and which will not impact www.adobe we see premier page going through some authoring changes and noticed during STAGE testing. since content is not published and issue is nothing related to this PR. PF below scree shot |
sigadamvenkata
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
JackySun9
added
run-nala
JackySun9
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
JackySun9
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
no bordersvariant to Accordion block #2755REVERTED
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: