Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2734

Merged
merged 5 commits into from
Aug 14, 2024
Merged

[Release] Stage to Main #2734

merged 5 commits into from
Aug 14, 2024

Conversation

nishantka and others added 5 commits August 13, 2024 16:08
* MWPW-132156: close (old) footer block modal when click outside

* UTs for footer region selection
* nofollow a link

* added units for nofollow link feature

* fixed liniting error
MWPW-156094: Unicode sequence %E2%80%8E is being added after il_he country code for MIQ json files | UAR | Milo
* Adding test case for federated modal

* Setting ogFetch on after each
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Aug 13, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

Copy link
Contributor

aem-code-sync bot commented Aug 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Aug 13, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (60cb005) to head (302e9be).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2734      +/-   ##
==========================================
+ Coverage   95.75%   95.89%   +0.14%     
==========================================
  Files         173      173              
  Lines       45733    45746      +13     
==========================================
+ Hits        43791    43870      +79     
+ Misses       1942     1876      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label Aug 13, 2024
@milo-pr-merge milo-pr-merge bot merged commit baef0d5 into main Aug 14, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants