-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Stage to Main #2722
[Release] Stage to Main #2722
Conversation
…th enablements (#2720) * initial fix * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * move where martech=off is used * move logic to handleEntitlements function --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* MWPW-156220: Support pa code and product code for checkout link configuration in addition to product family. * optimize perf * PR feedback * PR feedback
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2722 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 173 173
Lines 45656 45733 +77
=======================================
+ Hits 43717 43791 +74
- Misses 1939 1942 +3 ☔ View full report in Codecov by Sentry. |
adde download and open-in spectrum icons Co-authored-by: Dragana Trajkovic <[email protected]>
* MWPW-142166 One Page Gated * PR Changes
…de on stage (#2693) * calculate even on stage, find miloLibs and origin outside of loop * MWPW-155314 [MEP] Enable Entitlements + Operator (#2638) port over fixes --------- Co-authored-by: Jingle Huang <[email protected]>
* Require consent * Improve the check * Apply suggestions from code review Co-authored-by: Narcis Radu <[email protected]> * Fix linting issues * Fix linting and unit tests * Return faster * Track once consent is given * Fix unit tests * Remove defaults * Only listen to privacy once. --------- Co-authored-by: Narcis Radu <[email protected]>
@sigadamvenkata please use the If you don't have access to this, I can help out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed some page issues..added screen shots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the attached stage and prod comparison. stage UI has some issues like font inconsistency, price missing etc. need further investigation on PR which caused it
@sigadamvenkata the one on stage seems to be the correct one, the lines of the mini compare chart must have the same heights, so the following is correct. The one on production was probably a regression. |
verified the cc product pages. and stage changes are as per expected. hence approving the PR. thanks |
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: