Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2722

Merged
merged 6 commits into from
Aug 13, 2024
Merged

[Release] Stage to Main #2722

merged 6 commits into from
Aug 13, 2024

Conversation

vgoodric and others added 2 commits August 12, 2024 09:15
…th enablements (#2720)

* initial fix

* Update libs/features/personalization/personalization.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* move where martech=off is used

* move logic to handleEntitlements function

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* MWPW-156220: Support pa code and product code for

checkout link configuration in addition to product family.

* optimize perf

* PR feedback

* PR feedback
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Aug 12, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested review from a team as code owners August 12, 2024 09:16
Copy link
Contributor

aem-code-sync bot commented Aug 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Aug 12, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 98.80240% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.75%. Comparing base (7b9c7cf) to head (60cb005).
Report is 34 commits behind head on main.

Files Patch % Lines
libs/utils/logWebVitals.js 90.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2722   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         173      173           
  Lines       45656    45733   +77     
=======================================
+ Hits        43717    43791   +74     
- Misses       1939     1942    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adde download and open-in spectrum icons

Co-authored-by: Dragana Trajkovic <[email protected]>
* MWPW-142166 One Page Gated

* PR Changes
…de on stage (#2693)

* calculate even on stage, find miloLibs and origin outside of loop

* MWPW-155314 [MEP] Enable Entitlements + Operator (#2638)

port over fixes

---------

Co-authored-by: Jingle Huang <[email protected]>
* Require consent

* Improve the check

* Apply suggestions from code review

Co-authored-by: Narcis Radu <[email protected]>

* Fix linting issues

* Fix linting and unit tests

* Return faster

* Track once consent is given

* Fix unit tests

* Remove defaults

* Only listen to privacy once.

---------

Co-authored-by: Narcis Radu <[email protected]>
@sigadamvenkata
Copy link

we could see some discrepancies in the pages, and not sure which PR has caused it. please find below screen shots compare between STAGE and PROD
image
image

image

blocked the PR until then.

@mokimo @salonijain3 @narcis-radu

@mokimo
Copy link
Contributor

mokimo commented Aug 13, 2024

@sigadamvenkata please use the request changes feature to effectively block the pipeline, the label doesn't do anything
Screenshot 2024-08-13 at 10 45 22

If you don't have access to this, I can help out

Copy link

@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed some page issues..added screen shots

Copy link

@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the attached stage and prod comparison. stage UI has some issues like font inconsistency, price missing etc. need further investigation on PR which caused it

@yesil
Copy link
Contributor

yesil commented Aug 13, 2024

@sigadamvenkata the one on stage seems to be the correct one, the lines of the mini compare chart must have the same heights, so the following is correct. The one on production was probably a regression.

image

cc: @mokimo @overmyheadandbody

@sigadamvenkata
Copy link

verified the cc product pages. and stage changes are as per expected. hence approving the PR. thanks

@milo-pr-merge milo-pr-merge bot merged commit 0b80fa1 into main Aug 13, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants