Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2629

Merged
merged 4 commits into from
Jul 29, 2024
Merged

[Release] Stage to Main #2629

merged 4 commits into from
Jul 29, 2024

Conversation

… lh (#2610)

* MWPW-153245 [merch][analytics] dispatch web comp events, and let default lh

- dispatch merch wc shadow event for analytics,
- if lh attribute is already set, keep it, appending eventually mep information,
- also remove merch-sidenav dependency that is only consumed in CC atm,

* MWPW-153245 update deps

* fix dep

* MWPW-153245 update dependencies

* MWPW-153245 resolve chris' comment

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jul 25, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner July 25, 2024 09:16
Copy link
Contributor

aem-code-sync bot commented Jul 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jul 25, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (c0395ae) to head (add9745).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2629   +/-   ##
=======================================
  Coverage   95.69%   95.70%           
=======================================
  Files         172      172           
  Lines       45359    45362    +3     
=======================================
+ Hits        43406    43413    +7     
+ Misses       1953     1949    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…low (#2621)

* Correct error messages for duplicate files

* Improved variable naming
@aem-code-sync aem-code-sync bot temporarily deployed to stage July 25, 2024 09:20 Inactive
…ge.adobe.com (#2618)

* Fetch stage federal content from hlx.page instead of stage.adobe.com

* address PR feedback
…hen there is a disabled manifest (#2632)

add default order
@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label Jul 26, 2024
@milo-pr-merge milo-pr-merge bot merged commit 5028ef5 into main Jul 29, 2024
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants