generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Stage to Main #2432
Merged
Merged
[Release] Stage to Main #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to ensure Analytics fires (#2399) * move geomodal creation * Add initial switch * switch to daa-ll * pulling recs from vhargrave * roll back utils * remove await for martech in utils, add check in modals.js * remove unrelated changes * unit test coverage * add in check for called and resets on called --------- Co-authored-by: markpadbe <[email protected]>
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
==========================================
+ Coverage 95.60% 95.62% +0.01%
==========================================
Files 173 173
Lines 45327 45338 +11
==========================================
+ Hits 43334 43353 +19
+ Misses 1993 1985 -8 ☔ View full report in Codecov by Sentry. |
…2435) Run workflow on pr targets
avoided adding empty p in slots when there is no content
tedAir
approved these changes
Jun 6, 2024
JackySun9
approved these changes
Jun 6, 2024
skumar09
added
run-nala
Run Nala Test Automation against PR
and removed
run-nala
Run Nala Test Automation against PR
labels
Jun 6, 2024
meganthecoder
approved these changes
Jun 6, 2024
sigadamvenkata
approved these changes
Jun 10, 2024
sigadamvenkata
temporarily deployed
to
milo_pr_merge
June 10, 2024 05:39
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: