Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2432

Merged
merged 3 commits into from
Jun 10, 2024
Merged

[Release] Stage to Main #2432

merged 3 commits into from
Jun 10, 2024

Conversation

… to ensure Analytics fires (#2399)

* move geomodal creation

* Add initial switch

* switch to daa-ll

* pulling recs from vhargrave

* roll back utils

* remove await for martech in utils, add check in modals.js

* remove unrelated changes

* unit test coverage

* add in check for called and resets on called

---------

Co-authored-by: markpadbe <[email protected]>
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jun 6, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner June 6, 2024 09:15
Copy link
Contributor

aem-code-sync bot commented Jun 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jun 6, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (95a6593) to head (ca8ba03).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2432      +/-   ##
==========================================
+ Coverage   95.60%   95.62%   +0.01%     
==========================================
  Files         173      173              
  Lines       45327    45338      +11     
==========================================
+ Hits        43334    43353      +19     
+ Misses       1993     1985       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to stage June 6, 2024 11:57 Inactive
avoided adding empty p in slots when there is no content
@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner June 6, 2024 16:11
@tedAir tedAir self-requested a review June 6, 2024 16:52
@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label Jun 6, 2024
@skumar09 skumar09 added run-nala Run Nala Test Automation against PR and removed run-nala Run Nala Test Automation against PR labels Jun 6, 2024
@meganthecoder meganthecoder self-requested a review June 6, 2024 21:59
@milo-pr-merge milo-pr-merge bot merged commit 81d0085 into main Jun 10, 2024
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants