Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2423

Merged
merged 5 commits into from
Jun 6, 2024
Merged

[Release] Stage to Main #2423

merged 5 commits into from
Jun 6, 2024

Conversation

robert-bogos and others added 2 commits June 5, 2024 09:03
)

* test fix

* stage env - replace hostname on decorating links

* stage env - replace hostname on decorating links

* hotfix

* added stage domains mapping for links conversion

* hotfix

* consumer side stage domains mapping for links conversion

* hotfix

* extended unit tests
…ithub.com/adobecom/milo] (#2384)

* Removed DOMXSS vulnerability noticed by Kodiak

* lint errors fix

* removed txt version of the div

* using createTag instead of document.createElement

* lint error

* lint error

* refactored to simplify

* lint

---------

Co-authored-by: Denys Fedotov <[email protected]>
@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner June 5, 2024 09:03
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jun 5, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

Copy link
Contributor

aem-code-sync bot commented Jun 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jun 5, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@3ch023 3ch023 added the do not merge PR should not be merged yet label Jun 5, 2024
@3ch023 3ch023 added the run-nala Run Nala Test Automation against PR label Jun 5, 2024
Copy link
Contributor

@3ch023 3ch023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests failing

fixed failing unit tests
@3ch023 3ch023 removed the do not merge PR should not be merged yet label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (fe0adb4) to head (95a6593).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2423      +/-   ##
==========================================
- Coverage   95.64%   95.60%   -0.04%     
==========================================
  Files         173      173              
  Lines       45306    45327      +21     
==========================================
+ Hits        43331    43334       +3     
- Misses       1975     1993      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* test new icon

* added add icon

* added more icons

* added ai generate icon

* hotfix

* hotfix

* organised icons in alphabetical order

* formatting

* formatting

* formatting
Add offset to stage merges
@aem-code-sync aem-code-sync bot temporarily deployed to stage June 5, 2024 12:42 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to spectrum-narrative June 5, 2024 14:47 Inactive
@tedAir tedAir self-requested a review June 5, 2024 15:12
@milo-pr-merge milo-pr-merge bot merged commit e5bff30 into main Jun 6, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants