Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-142935 [Project PEP] PEP <> Geo Routing Modal Interactions #2403

Merged
merged 12 commits into from
Jun 17, 2024
Merged

MWPW-142935 [Project PEP] PEP <> Geo Routing Modal Interactions #2403

merged 12 commits into from
Jun 17, 2024

Commits on Jun 3, 2024

  1. modified georouting and pep so that pep only appears if a) GRM is not… 

    … shown or b) GRM is dismissed
    @sharmrj
    sharmrj committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6ff3c98 View commit details
    Browse the repository at this point in the history

  2. Unit test for GRM/PEP interaction

    @sharmrj
    sharmrj committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    2d0ee33 View commit details
    Browse the repository at this point in the history

  3. changed grmActive to geoRoutinActive

    @sharmrj
    sharmrj committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    164037a View commit details
    Browse the repository at this point in the history

  4. Fixed unit test for grm/pep interaction

    @sharmrj
    sharmrj committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0cff0ae View commit details
    Browse the repository at this point in the history

  5. removed unused imports

    @sharmrj
    sharmrj committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    50c63e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Cleaned up the implementation

    @sharmrj
    sharmrj committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    99e4d1d View commit details
    Browse the repository at this point in the history

  2. Changed from polling to listening for an event

    @sharmrj
    sharmrj committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f1b4a5e View commit details
    Browse the repository at this point in the history

  3. removed an unnecessary line

    @sharmrj
    sharmrj committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c2aadc2 View commit details
    Browse the repository at this point in the history

  4. Modified unit test

    @sharmrj
    sharmrj committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c52ffa9 View commit details
    Browse the repository at this point in the history

  5. Changed the implementation to use polling for any modal

    @sharmrj
    sharmrj committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d73dbf8 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge branch 'stage' of https://github.com/adobecom/milo into pep-geo… 

    …routing
    @sharmrj
    sharmrj committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d5fbaef View commit details
    Browse the repository at this point in the history

  2. Changed pep loading logic to poll for modals only after the close mod… 

    …al dialog comes through
    @sharmrj
    sharmrj committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2ad215a View commit details
    Browse the repository at this point in the history