Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-151238 Update commerce lib #2396

Closed

Conversation

bozojovicic
Copy link
Contributor

@bozojovicic bozojovicic commented May 31, 2024

@mokimo
Copy link
Contributor

mokimo commented May 31, 2024

Make sure the unit tests pass (restart them if needed) & that you provide a valid url for the PSI check.

Copy link
Contributor

aem-code-sync bot commented May 31, 2024

Page Scores Audits Google
/drafts/bozo/price-cta?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@afmicka afmicka added the run-nala Run Nala Test Automation against PR label Jun 3, 2024
@afmicka
Copy link
Contributor

afmicka commented Jun 3, 2024

@skumar09 @Dli3 two of the Nala video block tests are failing on PRs raised from the forks (like this one). There are more errors than expected due to CORS. Could you please take a look?

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@skumar09 skumar09 added run-nala Run Nala Test Automation against PR and removed run-nala Run Nala Test Automation against PR labels Jun 4, 2024
@3ch023 3ch023 added the commerce label Jun 5, 2024
@afmicka
Copy link
Contributor

afmicka commented Jun 6, 2024

The issue is fixed. However, as anticipated, there are cases where now 'per licence' text will appear in places they did not want it. Those prices need to be re-authored.
For example:
Middle card in individuals on PROD:
https://main--cc--adobecom.hlx.live/pl/creativecloud?martech=off#
Screenshot 2024-06-06 at 12 21 48

after the changes: https://main--cc--adobecom.hlx.live/pl/creativecloud?milolibs=mwpw151238-update-commerce-lib--milo--bozojovicic&martech=off
Screenshot 2024-06-06 at 12 21 53

@3ch023 @bozojovicic @yesil @npeltier What should we do about this? I have no idea how many of these cases there might be.

@afmicka afmicka added the verified PR has been E2E tested by a reviewer label Jun 6, 2024
@3ch023
Copy link
Contributor

3ch023 commented Jun 6, 2024

as discussed with business we need to freeze this PR till audit is done

@bozojovicic
Copy link
Contributor Author

This change is reverted in Tacocat https://git.corp.adobe.com/wcms/tacocat.js/pull/619 until we get audit results and the we will try again. So I will close this PR.

@bozojovicic bozojovicic closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants