-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-151238 Update commerce lib #2396
MWPW-151238 Update commerce lib #2396
Conversation
Make sure the unit tests pass (restart them if needed) & that you provide a valid url for the PSI check. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
The issue is fixed. However, as anticipated, there are cases where now 'per licence' text will appear in places they did not want it. Those prices need to be re-authored. after the changes: https://main--cc--adobecom.hlx.live/pl/creativecloud?milolibs=mwpw151238-update-commerce-lib--milo--bozojovicic&martech=off @3ch023 @bozojovicic @yesil @npeltier What should we do about this? I have no idea how many of these cases there might be. |
as discussed with business we need to freeze this PR till audit is done |
This change is reverted in Tacocat https://git.corp.adobe.com/wcms/tacocat.js/pull/619 until we get audit results and the we will try again. So I will close this PR. |
Includes: https://git.corp.adobe.com/wcms/tacocat.js/pull/612
Resolves: MWPW-151238 and MWPW-151238
Test URLs: