Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2328

Merged
merged 9 commits into from
May 20, 2024
Merged

[Release] Stage to Main #2328

merged 9 commits into from
May 20, 2024

Conversation

milo-pr-merge[bot]
Copy link
Contributor

@milo-pr-merge milo-pr-merge bot commented May 17, 2024 •
edited by mokimo
Loading

Zero impact / PR workflow improvements:

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

seanchoi-dev and others added 4 commits May 17, 2024 00:39
@seanchoi-dev
[MWPW-147480] Fix: Badge overlapping title (#2275)
700ddae 
* Fix: Badge overlapping title

* Different style.

* merch card class unit test added

* using spacing-s instead

* fixing fat badge

* fixing rtl badge

* mobile adjustment
@meganthecoder
MWPW-143912 New Media Variant: Medium Compact (#2243)
500a2bd 
* MWPW-143912 New Media Variant: Medium Compact

* move block size to prevent default size issues
@robert-bogos
MWPW-138032: added tags to LANA logs (#2314)
4dbafe1 
* added tags to lana logs

* added tags to lana logs
@yesil
MWPW-147472: auto adjust commerce iframe (#2316)
cdb1973 
* MWPW-147472: auto adjust commerce iframe.

* typo fix

* fix for potential bfcache issues

* improve modal selector query w.r.t hash

improve test.

* MWPW-147472: add fail safe to commerce frame resizing
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented May 17, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented May 17, 2024 •
edited
Loading

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.41860% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 95.64%. Comparing base (682f549) to head (285075f).
Report is 1 commits behind head on main.

Files Patch % Lines
libs/blocks/modal/modal.merch.js 55.55% 8 Missing ⚠️
libs/blocks/article-feed/article-helpers.js 0.00% 1 Missing ⚠️
libs/blocks/quiz-entry/quiz-entry.js 0.00% 1 Missing ⚠️
libs/blocks/quiz-results/quiz-results.js 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
- Coverage   95.65%   95.64%   -0.02%     
==========================================
  Files         173      173              
  Lines       45031    45055      +24     
==========================================
+ Hits        43076    43091      +15     
- Misses       1955     1964       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sharath-kannan and others added 2 commits May 17, 2024 11:08
@sharath-kannan
fix(MWPW-148021):Table min width set to screen size. (#2287)
3dab815 
Table min width set to screen width
@mokimo
[MWPW-148312] Stage automation, improve branch->stage merge process (#…
a3b1d0b 
…2322)

* Add team reviewers

* Add a safeguard to only update the PR body if it exists

* Remove extra space

* Move the team mentions to an array

* Improved error handling
@aem-code-sync aem-code-sync bot temporarily deployed to stage May 17, 2024 11:18 Inactive
@tedAir tedAir self-requested a review May 17, 2024 17:10
@JackySun9 JackySun9 added MIQ SOT👌 run-nala Run Nala Test Automation against PR labels May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@Blainegunn Blainegunn merged commit 5a5a365 into main May 20, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roycethan Roycethan Roycethan approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@seanchoi-dev seanchoi-dev seanchoi-dev approved these changes

@Dli3 Dli3 Dli3 approved these changes

@tedAir tedAir tedAir approved these changes

@hparra hparra Awaiting requested review from hparra hparra is a code owner

@meganthecoder meganthecoder Awaiting requested review from meganthecoder meganthecoder is a code owner

@JasonHowellSlavin JasonHowellSlavin Awaiting requested review from JasonHowellSlavin JasonHowellSlavin is a code owner

@Brandon32 Brandon32 Awaiting requested review from Brandon32 Brandon32 is a code owner

@colloyd colloyd Awaiting requested review from colloyd colloyd is a code owner

@sabyamon sabyamon Awaiting requested review from sabyamon sabyamon is a code owner

@fullcolorcoder fullcolorcoder Awaiting requested review from fullcolorcoder fullcolorcoder is a code owner

@elaineskpt elaineskpt Awaiting requested review from elaineskpt

@echampio-at-adobe echampio-at-adobe Awaiting requested review from echampio-at-adobe

@ryanmparrish ryanmparrish Awaiting requested review from ryanmparrish ryanmparrish is a code owner

@rgclayton rgclayton Awaiting requested review from rgclayton rgclayton is a code owner

Assignees
No one assigned
Labels
BAcom SOT 👌 DC SOT 👌 Homepage SOT 👌 MIQ SOT👌 run-nala Run Nala Test Automation against PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.