Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-147267: Mini Compare Chart Card UX Feedback #2320

Merged
merged 8 commits into from
Jun 6, 2024
Merged

MWPW-147267: Mini Compare Chart Card UX Feedback #2320

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f36c00
avoided adding empty p in slots when there is no content
mirafedas May 16, 2024
f66edcf
Merge branch 'stage' into MWPW-147267-space-under-the-price
mirafedas May 16, 2024
1e2d912
Merge branch 'stage' into MWPW-147267-space-under-the-price
mirafedas May 17, 2024
52f3ac7
Merge branch 'stage' into MWPW-147267-space-under-the-price
mirafedas May 21, 2024
8823089
Merge branch 'stage' into MWPW-147267-space-under-the-price
mirafedas May 22, 2024
b413854
Merge branch 'stage' into MWPW-147267-space-under-the-price
mirafedas May 28, 2024
1be1985
Merge branch 'stage' into MWPW-147267-space-under-the-price
mirafedas May 31, 2024
37d74d5
Merge branch 'stage' into MWPW-147267-space-under-the-price
mirafedas Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/blocks/merch-card/merch-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const isHeadingTag = (tagName) => /^H[2-5]$/.test(tagName);
const isParagraphTag = (tagName) => tagName === 'P';

const appendSlot = (slotEls, slotName, merchCard) => {
if (slotEls.length === 0 && merchCard.variant !== MINI_COMPARE_CHART) return;
if (slotEls.length === 0 || merchCard.variant !== MINI_COMPARE_CHART) return;
const newEl = createTag(
'p',
{ slot: slotName, class: slotName },
Expand Down
Loading