[Release] Stage to Main #2260
Merged
[Release] Stage to Main #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Blainegunn
commented
May 3, 2024
•
Blainegunn
commented
- MWPW-146370: Enable dynamic comment threshold via metadata #2166
- MWPW-147284: discard default params in merch link #2231
- MWPW-147002-Fix spacing issue between button on table header left variation in RTL #2241
- Project pep #2235 (High Priority)
- Sidekick publish style issues #2253
- MWPW-146796 Add localization to Marketo destination URLs #2200
- MWPW-146796 Fix Marketo unit test #2262 ( Fixes failing tests from 2200 )
- [MWPW-147848] Remove e-mail notifications for PRs #2265 (zero impact)
- MWPW-147808 - Create README.md for mobile app banner #2263 (zero impact)
…s) (#2217) * MWPW-147027: CTA flowing out of mini compare card (due to long strings) * footer fix * Update merch-card.js * Update merch-card.js
* MWPW-147149: Prevent multiple download links in the same marquee or merch-card * add upgrade use case. * add comment * typo fix * improve href attribute setting * commerce.js from develop
* add job info to job processes * add job info updates * ui dialing * finish up UI and refactored a little * update label * unit tests to support new functionality * package index jobs into one * feedback from demo * fix unit test * code cov * get full code cov * can test copy to clipboard in process component * fix tabs test
* MWPW-146784 Add new default IMS scopes * MWPW-146784 Add new default IMS scopes --------- Co-authored-by: Snehal Sonawane <[email protected]> Co-authored-by: Bandana Laishram <[email protected]>
* MWPW-146070: Upgrade unav to 1.1 * MWPW-146784 Add new default IMS scopes * MWPW-146784 Add new default IMS scopes --------- Co-authored-by: Snehal Sonawane <[email protected]> Co-authored-by: Bandana Laishram <[email protected]>
* Comment threshold for consumers * Comment threshold for consumers * Adding test for Reviews JS --------- Co-authored-by: Blaine Gunn <[email protected]>
* MWPW-147284: discard default params in merch link that are generated via OST. * update tests * fix typo
…iation in RTL (#2241) Update table.css
* [MWPW-139990] PEP prompt * MWPW-142617: Microsoft Edge & Chrome Win - progress bar not completely loaded (#1882) * hotfix * refactor: changed loader animation logic * update * revert update * more gpu acceleration for pep loader * hotfix * hotfix * [MWPW-141023] PEP authoring (#1889) * MWPW-141021: Project PEP Accessibility Requirements (#1853) * [MWPW-139990] PEP prompt * pep accessibility requirements * hotfix * hotfixes * initial focus on close icon * implementing feedback * hotfix * [MWPW-139990] PEP prompt * MWPW-142617: Microsoft Edge & Chrome Win - progress bar not completely loaded (#1882) * hotfix * refactor: changed loader animation logic * update * revert update * more gpu acceleration for pep loader * hotfix * hotfix * [MWPW-141023] PEP authoring (#1889) * implementing feedback * css variables * hotfix: moved css variables * hotfix --------- Co-authored-by: Rares Munteanu <[email protected]> * MWPW-142622: [Project PEP] Close button focus (#1897) * [MWPW-139990] PEP prompt * MWPW-142617: Microsoft Edge & Chrome Win - progress bar not completely loaded (#1882) * hotfix * refactor: changed loader animation logic * update * revert update * more gpu acceleration for pep loader * hotfix * hotfix * [MWPW-141023] PEP authoring (#1889) * hotfix: blue outline on close button when focused * hotfix --------- Co-authored-by: Rares Munteanu <[email protected]> * MWPW-141020: [Project PEP] Implement Analytics Enablement (#1951) * pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label * [MWPW-141050] Fetch profile for PEP * [MWPW-141025] Integrate XLG with PEP * [MWPW-142625] PEP relative to App Switcher * MWPW-144108: Project PEP unit tests (#2136) * unit tests for pep * fixes for gnav unit tests * optimizing pep unit tests * MWPW-146582: PEP fixes (#2144) * added aria-label attribute to pep close button * force load imslib.min.js * revert force load imslib.min.js * changed aria label for close button * pep final touches * [MWPW-147145] Allow SVG in PEP Prompt; change redirect method --------- Co-authored-by: Robert Bogos <[email protected]> Co-authored-by: Robert Bogos <[email protected]>
Sidekick publish styling issues * Fix for intermittent style issues on publish button. Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Ryan Clayton <[email protected]>
* MWPW-146796 Add localization to Marketo destination URLs * PR Changes --------- Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Blaine Gunn <[email protected]>
Blainegunn
requested review from
nkthakur48,
chrischrischris,
auniverseaway,
a team,
ryanmparrish,
Sartxi,
Brandon32,
meganthecoder,
JasonHowellSlavin,
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309 and
sonawanesnehal3
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Blainegunn
added
run-nala
|
Opened #2261 to revert #2200 due to failing unit tests. If @Brandon32 fixes the unit tests in the meantime, we can also merge that |
|
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2260 +/- ##
==========================================
- Coverage 95.68% 95.64% -0.04%
==========================================
Files 165 166 +1
Lines 43542 43871 +329
==========================================
+ Hits 41663 41961 +298
- Misses 1879 1910 +31 ☔ View full report in Codecov by Sentry. |
sigadamvenkata
approved these changes
May 7, 2024
* Create README.md * Update README.md * Update libs/blocks/mobile-app-banner/README.md Co-authored-by: Okan Sahin <[email protected]> --------- Co-authored-by: Okan Sahin <[email protected]>
Roycethan
approved these changes
May 7, 2024
JackySun9
approved these changes
May 7, 2024
tedAir
approved these changes
May 7, 2024
meganthecoder
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.