Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-144549 CTA alignment for Text, Icon, and Media Blocks #2209

Merged
merged 3 commits into from
May 8, 2024

Conversation

@meganthecoder meganthecoder added high-impact Any PR that may affect consumers run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Apr 25, 2024
Copy link
Contributor

aem-code-sync bot commented Apr 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (9c1339b) to head (f5ceb07).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2209      +/-   ##
==========================================
+ Coverage   95.64%   95.65%   +0.01%     
==========================================
  Files         166      166              
  Lines       43871    43896      +25     
==========================================
+ Hits        41961    41990      +29     
+ Misses       1910     1906       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +170 to +171
.text-block.icon-inline .foreground [class^="body-"],
.text-block.icon-inline .foreground .cta-container {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only update from the previous PR #2098

@meganthecoder
Copy link
Contributor Author

@JasonHowellSlavin @Ruchika4 @ryanmparrish @elan-tbx

I'd appreciate your re-review on this. The only new code is in text.css, lines 170-171.

You've previously reviewed this PR (here: #2098) but there was an issue found during stage testing (here: #2203 (comment)). It was found in the UAR quiz and applies to all Text block inline-icon variants.

I've added that variant to the text-alignment-all page and you can also see it in the fragment from the UAR quiz on CC: https://main--cc--adobecom.hlx.live/cc-shared/fragments/uar/marquee/marquee-plan/cci-cct?milolibs=methomas-text-alignment

Thanks!

CC @JackySun9 @Brandon32

Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

Copy link
Contributor

@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I just added a few possible improvements

Comment on lines +32 to +33
const ctaArea = medias[0].querySelector('.cta-container .action-area');
expect(ctaArea).to.exist;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We can turn this into a one liner by not caching ctaArea.
You can just do: expect(medias[0].querySelector('.cta-container .action-area')).to.exist;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I agree but I think it improves readability of the tests so I'll keep them as is.

test/blocks/media/media.test.js Show resolved Hide resolved
test/blocks/text/text.test.js Show resolved Hide resolved
test/blocks/text/text.test.js Show resolved Hide resolved
@JasonHowellSlavin JasonHowellSlavin added the verified PR has been E2E tested by a reviewer label May 7, 2024
@meganthecoder meganthecoder added Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels May 7, 2024
@github-actions github-actions bot merged commit c521331 into stage May 8, 2024
12 checks passed
@github-actions github-actions bot deleted the methomas/text-alignment branch May 8, 2024 06:40
@github-actions github-actions bot mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-impact Any PR that may affect consumers Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants