-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-146209 [MILO][MEP] MEP param override does not work if manifest sent by Target and pzn and chosen column not in Target #2119
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2119 +/- ##
==========================================
+ Coverage 96.35% 96.40% +0.05%
==========================================
Files 165 165
Lines 43534 43543 +9
==========================================
+ Hits 41947 41979 +32
+ Misses 1587 1564 -23 ☔ View full report in Codecov by Sentry. |
@vgoodric these changes are breaking mep preview functionality and our promotions nala tests, thats why it was not passing. We have added those tests recently so please do not skip run-nala label. If you go to the url below and try to set to default any of the manifests and preview, it will not go through. It reloads again with all the manifests set to all. Could you please review? It works on: https://main--milo--adobecom.hlx.live/drafts/nala/features/promotions/promo-default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review MEP preview functionality on existing pages with multiple manifests like UK acom homepage as well. The changes are breaking it there too.
https://main--homepage--adobecom.hlx.page/uk/homepage/index-loggedout?milolibs=mepparamtarget
@afmicka I turned off nala because there was something broken on stage as well. So it wasn't instructive. But I think everything is working now. Can you confirm? |
Co-authored-by: Okan Sahin <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vgoodric no verified label. Please add |
Steps to reproduce:
Solution: don't check if the selected variant should be overridden until the manifests have been consolidated in cleanAndSortManifestList function
Example page setup that is sending an old version of manifest via Target and is trying to spoof a new column not sent by Target:
Resolves: MWPW-145303
Test URLs:
Also included a tiny CSS fix for "instant" links