generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-138882: Commerce v3 Merch Card #1541
Merged
Merged
Commits on Nov 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 802d0a5 - Browse repository at this point
Copy the full SHA 802d0a5View commit details
Commits on Nov 16, 2023
-
[MWPW-139039] Table css update for RTL (#1549)
rtl styles for table.
Configuration menu - View commit details
-
Copy full SHA for 2352e3c - Browse repository at this point
Copy the full SHA 2352e3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66f2264 - Browse repository at this point
Copy the full SHA 66f2264View commit details -
Configuration menu - View commit details
-
Copy full SHA for 722e3b5 - Browse repository at this point
Copy the full SHA 722e3b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fcd512 - Browse repository at this point
Copy the full SHA 5fcd512View commit details -
Configuration menu - View commit details
-
Copy full SHA for e72809a - Browse repository at this point
Copy the full SHA e72809aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31c996e - Browse repository at this point
Copy the full SHA 31c996eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3258bf4 - Browse repository at this point
Copy the full SHA 3258bf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c039503 - Browse repository at this point
Copy the full SHA c039503View commit details -
* MWPW-129984 Contextual Search without Helpx (#1493) * MWPW-129984 Contextual Search without Helpx * MWPW-138197 Fix Adobe Logo on Safari (#1518) * MWPW-138197 Fix Adobe Logo on Safari * cr * MWPW-138822: Quiz debugging features; bug fixes (#1524) * MWPW-132437: [Q] Mirror margins for RTL locales (#1480) MWPW-132437: Mirror margins for RTL locales * Quiz Results Debugging (#1476) * MWPW-125561 - UAR Results Block (#636) * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * UAR Quiz Block Initial Commit (#682) * Initial commit for question flow in UAR * Refactoring v1 * Refactoring v2 * Refactoring CSS * Mwpw 125561 uar results block - data model updates (#680) * MWPW-125561 - UAR Results Block * Initial commit * Basic UAR results * Nested UAR results * Style support Resolves: [MWPW-NUMBER](MWPW-URL) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://uar-integration--milo--adobecom.hlx.page/?martech=off * Adjustments to match data structure from quizzes * Finalized UAR Results (#729) * Finalized UAR Results * Lana logging and a debug param to stop redirects (MWPW-125185) * Set a value for pageload analytics (MWPW-128939) * Unit tests (MWPW-130870) Resolves: [MWPW-125185](https://jira.corp.adobe.com/browse/MWPW-125185) Resolves: [MWPW-128939](https://jira.corp.adobe.com/browse/MWPW-128939) Resolves: [MWPW-130870](https://jira.corp.adobe.com/browse/MWPW-130870) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * Set error strings as an exported variable. Used the exported variable in unit tests. * [MWPW-125908] [UAR] Step indicator addition to quiz (#714) * Step indicator addition to quiz * Refactored to use visibility for performance * Hiding stray data * Refactored quiz js/css to not be hard coded and add padding on mobile * css refactor for colors, spacing, better selectors * class naming refactor * Adding the current locale code to the local storage key (#800) Co-authored-by: Honwai Wong <[email protected]> * [UAR] cards responsive (#844) * [UAR] Card refinement (#873) * spacing fixes, flex for leftover cards, selected card fix * spacing tweak, dot indicator adjustment * MWPW-125274 - UAR Analytics (#871) * Refactoring question flow and adding analytics data * Adding button analytics data * Setting pageLoadHash in local storage * Refactoring * Adding guardrail around result parsing * MWPW-133219: Hide default content before the preact app loads (#898) * Hide the original, classless div elements within the quiz block by default. Then use a specific selector to restore the wrapper div added by the preact app. * Hide div elements within the quiz that aren't marked with a specific class of their own * Removing code to hide siblings of .quiz-container since they will already be hidden * MWPW-127110 - Quiz footer fragment based on string.json (#895) * quiz footer fragment Loader * quiz footer fragment * quiz footer fragment * quiz footer fragment * quiz footer fragment * test * test * stepIndicator correction --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-133738: Use a different comparison to process question values (#949) * MWPW-133759 - Adding logic to account for single products grouped together (#941) * Adding logic to account for single product grouped together * Refactoring * MWPW-133268 - Rename uar-results to quiz-results (#962) * renamed all block files and references * updated unit tests * updated debug query params Resolves: [MWPW-133268](https://jira.corp.adobe.com/browse/MWPW-133268) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * [UAR] - Alternate quiz data (#953) * MWPW-126143 added alternate path for JSON data via search params * empty * Fixed step indicator * Changed to use layouteffect, tests * Reverted slash in query param scenario * Refactored tests and quiz url sourcing * MWPW-134269 - Adding nested fragments based upon the primary product as well as secondary (#1071) * Adding nested fragments based on primary and secondary products * Refactoring * Refactoring - v2 --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134131 - Fixing issue when there are more than one rule with same number of grouping (#1112) * Fixing issue when there are more than one rule with same number of grouping * Addressing review comments * MWPW-135198 - Optimizes quiz-results DOM handling (#1117) * Removed a querySelectorAll * Removed iteration through metadata divs * Add lana logging if the block has been misconfigured Resolves: [MWPW-135198](https://jira.corp.adobe.com/browse/MWPW-135198) * MWPW-132277 - Breakpoint content for Quiz Results (#1128) * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * MWPW-132277 work in progress * setting phone-only as default --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Narcis Radu <[email protected]> * MWPW-135125 Quiz button fix (#1153) * button responsive fix * height setting to min-height --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * [UAR] Quiz URL States (#1149) * Managing state via url, support back button, hydrate state with params * Refactored url management & handled existing redirect params from results.json * added handler for back button with known params present * Defered popstate * Refactored to fix errors * Fixed back button click new option bug --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-134986 - Rendering nested fragments in the order of products (#1186) Rendering nested fragments in the order of products * MWPW-134823 - QUIZ - Fix Acessibility warning (#1192) clean up lorems Co-authored-by: Elaine Borges <[email protected]> * MWPW-135442 - Fixing the issue of NOT operator when the order of selection is changed (#1200) * Fixing the issue of NOT operator when the order of selection is changed * Refactoring * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing (#1208) * MWPW-135903: If nestedObject[fragKey] exists, append to it instead of replacing * MWPW-135903: Feedback from Okan * MWPW-135296 - Quiz css and related markup cleanup (#1219) * MWPW-135296 - Quiz css and related markup cleanup * Drastically simplifies quiz css, removing unused css * Simplified markup, removing unused classes and standardizing the rest * Remove caas related css and classes that were creating linting errors * add icon and cover-image types to cards * add top and bottom classes to progress indicators * set all styling to match the comps from consonant for all devices Resolves: [MWPW-135296](https://jira.corp.adobe.com/browse/MWPW-135296) * fix word breaking on card text * pr feedback adjustments * MWPW-125774 - Quiz block accessibility (#1243) * MWPW-125774 - Quiz block accessibility * Quiz options can now be tabbed to with the keyboard * Quiz options can be activated with space or enter keys * Focus is reset to the top of the quiz when moving to the next question Resolves: [MWPW-125774](https://jira.corp.adobe.com/browse/MWPW-125774) * PR feedback to adjust mobile quiz-option width * fix for icons shrinking on mobile longer text * MWPW-133119 - Adding Unit Tests for Quiz (Utils.js) (#1254) * Adding unit tests for quiz * Refactoring * Refactoring again * Quiz tests (#1260) * MWPW-134984, tests. * cleanup * Remove file * MWPW-136619: Update CODEOWNERS for quiz and quiz-results (#1280) * MWPW-136619: Update CODEOWNERS for quiz and quiz-results * MWPW-136619: Removing extra @ * Update libs/blocks/quiz-results/quiz-results.js adjust logged message for analytics when in debug Co-authored-by: Chris Peyer <[email protected]> * PR 1264 quiz.js feedback refactor (#1289) * PR 1264 quiz.js feedback refactor * Clarifying const naming * MWPW-136688 Added quiz and quiz results to MILO_BLOCKS (#1299) Added quiz and quiz results to MILO_BLOCKS * PR 1264 quiz_results.js feedback (#1298) Resolves quiz-results.js feedback in PR #1264 * PR 1264 utils.js feedback refactor (#1329) * Addressing review comments for the main PR * Refactoring --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135730 - Results card-list alignment correction (#1349) results card-list alignment correction Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-115213 - Addressing review comments (#1356) * MWPW-136165 - Background reset for quiz footer (#1379) * Allow section metadata dark with static links style without background Resolves: [MWPW-136165](https://jira.corp.adobe.com/browse/MWPW-136165) * MWPW-136162 [UAR] Refactored last step signal to dot indicators (#1369) * MWPW-136162 Refactored last step signal to dot indicators * MWPW-136162 refactored empty array --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-135119: redirect to result page if next is valid URL * Revert "MWPW-135119: redirect to result page if next is valid URL" This reverts commit 9d43c15. * MWPW-137456 refactored for last step detection (#1400) * Quiz property name updates (#1413) * MWPW-137651 - Quiz property name adjustments * Renamed properties to make them more author friendly Resolves: [MWPW-137651](https://jira.corp.adobe.com/browse/MWPW-137651) * pr feedback fixes for storage * MWPW-135119: Redirect to result pages without loading results.json (#1403) * update divider-inherit css to support different color divider * MWPW-135119: redirect to result page if next is valid URL * fix eslint error * update code according to feedback * fix eslint --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Erich Champion <[email protected]> * MWPW-136372 - Fixing stuffs to make performance great again.. (#1429) * Fixing stuffs to make performance great again.. * Refactoring * Fixing tests --------- Co-authored-by: Erich Champion <[email protected]> * MWPW-137193 quiz-result validation improvements (#1451) MWPW-137193 - Quiz results validation improvements * checks for an empty basic fragment object Resolves: [MWPW-137193](https://jira.corp.adobe.com/browse/MWPW-137193) Co-authored-by: Erich Champion <[email protected]> * MWPW-125569 Adds debugging functionality, cleans code * removed handlePopState and cleaned up eslint messages. * Cleaned up URL better * Console.log support for paper trail * added promise to prevent race condition not copying * Update quiz.js --------- Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-138713: [Q] Bogus dependency of step indicator on background (#1482) --------- Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> * MWPW-137634 footer unit tests (#1471) * feat: footer unit tests * feat: unit tests for mobile, tablet, and wide screen layouts * hotfix * optimizing * Improving Code Readability * hotfix: added link for favicon * hotfix * hotfix * increased branches code coverage * increased branches code coverage for global footer --------- Co-authored-by: Narcis Radu <[email protected]> * MWPW-138921 Fixing popup promo image size (#1516) With rearrangement of CSS in #1470 the promoaside icon styles are overriding promoaside popup variant icon styles. Fixing the css to prioritize popup style for popup promo. Resolves: MWPW-138921 Test URLs: Before: https://main--milo--adobecom.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off After: https://mwpw-138921--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/popuppromo?martech=off * MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440) * grid-width section support for .contained content * Conditional check for authored section up styles. * PR refactor feedback * Added test coverage for new chart functionality w/ section-meta styles * Delete robots.txt * Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update" (#1534) Revert "MWPW-137076 - Section metadata style: `grid width` breaking consumer layouts & Charts grid update (#1440)" This reverts commit 4874714. * Add workflow to run Nala tests on CircleCI for Milo Stage (#1533) Add workflow to run tests on CircleCI for Stage Co-authored-by: Aaron Mauchley <[email protected]> * Support for prod non milo environment (#1537) * Create robots.txt * MWPW-138347 Font display optional (#1535) * MWPW-132986 - Add spacing around library blocks (#1438) * Block spacing * Add spacing to blocks copied and pasted from the block library. * Removing spacing from getHtml to avoid duplicate spacing being added to grouped patterns. Adding spacing to the new blob. --------- Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Chris Millar <[email protected]> * MWPW-138962: Bacom-blog Article Feed Issue (#1513) * Adding some logic to determine which project is loading article feed * Adding null operator * MWPW-138565 | Gnav overlapping with popup promobar (#1519) Popup promobar takes a 16px gap from the bottom to have a floating effect. The current bottom attribute is making the promobar overlap with the Gnav. Changing the bottom attribute and applying it on section so that the promobar does not overlap with gnav when previewed in fragment. Sample page links - https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/creativecloud-default Resolves: MWPW-138565 Test URLs: Before: https://main--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off After: https://mwpw-138565--milo--aishwaryamathuria.hlx.page/drafts/mathuria/promobar/fragments/popup-promo-aside?martech=off * MWPW-139338: mocked ims for gnav.js unit tests (#1545) mocked ims for gnav.js unit tests * mwpw-139041 Sidekick breaks if merch link is used --------- Co-authored-by: Brandon Marshall <[email protected]> Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Sabya <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: Robert Bogos <[email protected]> Co-authored-by: Aishwarya Mathuria <[email protected]> Co-authored-by: Ryan Parrish <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: James Tsay <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]> Co-authored-by: Shahbaz Khan <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Jason Slavin <[email protected]> Co-authored-by: vivgoodrich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 07a9ef3 - Browse repository at this point
Copy the full SHA 07a9ef3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c0e9ac - Browse repository at this point
Copy the full SHA 8c0e9acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 511d061 - Browse repository at this point
Copy the full SHA 511d061View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c0558a - Browse repository at this point
Copy the full SHA 2c0558aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d7a5fb - Browse repository at this point
Copy the full SHA 5d7a5fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dd5736 - Browse repository at this point
Copy the full SHA 7dd5736View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf1df1c - Browse repository at this point
Copy the full SHA cf1df1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 210cd81 - Browse repository at this point
Copy the full SHA 210cd81View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.