Skip to content

Commit

Permalink
MWPW-151392: Sorting button/menu issues on Mobile (#2690)
Browse files Browse the repository at this point in the history
* changed the swc version to 0.46.0

* added polyfills import

* corrected import

* corrected import

* added warning about polyfills in readme

* fixed typos and changed imports

* corrected import

* brought back the loadScript

* correction for the readme
  • Loading branch information
mirafedas authored Aug 21, 2024
1 parent 8f8834b commit 7ba11cd
Show file tree
Hide file tree
Showing 42 changed files with 9,940 additions and 1,008 deletions.
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
.aem/*
coverage
logs/*
node_modules
*node_modules
.DS_Store
.idea
.iml
.env
**/mas/stats.json
**/mas/*/stats.json
3 changes: 3 additions & 0 deletions libs/blocks/merch-card-collection/merch-card-collection.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,10 @@ export default async function init(el) {
const cardsDataPromise = fetchCardsData(config, type, el);

const merchCardCollectionDep = import('../../deps/mas/merch-card-collection.js');
const polyfills = import('../merch/merch.js');
await polyfills;
let deps = [
polyfills,
merchCardCollectionDep,
import('../merch-card/merch-card.js'),
import('../../deps/mas/merch-card.js'),
Expand Down
2 changes: 1 addition & 1 deletion libs/blocks/merch/merch.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export async function polyfills() {
polyfills.promise = Promise.resolve();
} else {
const { base } = getConfig();
polyfills.promise = loadScript(`${base}/deps/custom-elements.js`);
polyfills.promise = await loadScript(`${base}/deps/custom-elements.js`);
}
return polyfills.promise;
}
Expand Down
730 changes: 355 additions & 375 deletions libs/features/mas/package-lock.json

Large diffs are not rendered by default.

59 changes: 36 additions & 23 deletions libs/features/mas/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,29 +15,42 @@
"build": "npm run build --workspaces"
},
"dependencies": {
"@spectrum-web-components/action-button": "^0.43.0",
"@spectrum-web-components/action-menu": "^0.43.0",
"@spectrum-web-components/button": "^0.43.0",
"@spectrum-web-components/button-group": "^0.43.0",
"@spectrum-web-components/checkbox": "^0.43.0",
"@spectrum-web-components/dialog": "^0.43.0",
"@spectrum-web-components/icon": "^0.43.0",
"@spectrum-web-components/icons": "^0.43.0",
"@spectrum-web-components/icons-workflow": "^0.43.0",
"@spectrum-web-components/link": "^0.43.0",
"@spectrum-web-components/menu": "^0.43.0",
"@spectrum-web-components/overlay": "^0.43.0",
"@spectrum-web-components/popover": "^0.43.0",
"@spectrum-web-components/progress-circle": "^0.43.0",
"@spectrum-web-components/radio": "^0.43.0",
"@spectrum-web-components/reactive-controllers": "^0.43.0",
"@spectrum-web-components/search": "^0.43.0",
"@spectrum-web-components/sidenav": "0.42.1",
"@spectrum-web-components/split-button": "^0.43.0",
"@spectrum-web-components/tabs": "^0.43.0",
"@spectrum-web-components/theme": "^0.43.0",
"@spectrum-web-components/tooltip": "^0.43.0",
"@spectrum-web-components/tray": "^0.43.0",
"@spectrum-web-components/action-button": "^0.46.0",
"@spectrum-web-components/action-menu": "^0.46.0",
"@spectrum-web-components/alert-dialog": "^0.46.0",
"@spectrum-web-components/base": "^0.46.0",
"@spectrum-web-components/button": "^0.46.0",
"@spectrum-web-components/button-group": "^0.46.0",
"@spectrum-web-components/checkbox": "^0.46.0",
"@spectrum-web-components/close-button": "^0.46.0",
"@spectrum-web-components/dialog": "^0.46.0",
"@spectrum-web-components/divider": "^0.46.0",
"@spectrum-web-components/field-label": "^0.46.0",
"@spectrum-web-components/help-text": "^0.46.0",
"@spectrum-web-components/icon": "^0.46.0",
"@spectrum-web-components/icons": "^0.46.0",
"@spectrum-web-components/icons-ui": "^0.46.0",
"@spectrum-web-components/icons-workflow": "^0.46.0",
"@spectrum-web-components/link": "^0.46.0",
"@spectrum-web-components/menu": "^0.46.0",
"@spectrum-web-components/modal": "^0.46.0",
"@spectrum-web-components/overlay": "^0.46.0",
"@spectrum-web-components/picker": "^0.46.0",
"@spectrum-web-components/popover": "^0.46.0",
"@spectrum-web-components/progress-circle": "^0.46.0",
"@spectrum-web-components/radio": "^0.46.0",
"@spectrum-web-components/reactive-controllers": "^0.46.0",
"@spectrum-web-components/search": "^0.46.0",
"@spectrum-web-components/shared": "^0.46.0",
"@spectrum-web-components/sidenav": "^0.46.0",
"@spectrum-web-components/split-button": "^0.46.0",
"@spectrum-web-components/tabs": "^0.46.0",
"@spectrum-web-components/textfield": "^0.46.0",
"@spectrum-web-components/theme": "^0.46.0",
"@spectrum-web-components/toast": "^0.46.0",
"@spectrum-web-components/tooltip": "^0.46.0",
"@spectrum-web-components/tray": "^0.46.0",
"@spectrum-web-components/underlay": "^0.46.0",
"lit": "^2.8.0"
},
"devDependencies": {
Expand Down
Loading

0 comments on commit 7ba11cd

Please sign in to comment.