childNodes instead of specific elements

adobecom · Sep 19, 2024 · 5d09c50 · 5d09c50
1 parent 24c6a56
commit 5d09c50
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/libs/blocks/hero-marquee/hero-marquee.js b/libs/blocks/hero-marquee/hero-marquee.js
@@ -140,9 +140,8 @@ function isElementEmpty(element) {
     }
   }
   if (element.childNodes.length === 0) return true;
-  const nonEmptyElements = ['IMG', 'VIDEO', 'PICTURE', 'IFRAME', 'OBJECT', 'EMBED'];
   for (const child of element.children) {
-    if (nonEmptyElements.includes(child.tagName) || !isElementEmpty(child)) {
+    if (child.hasChildNodes()) {
       return false;
     }
   }
@@ -184,6 +183,7 @@ export default async function init(el) {
   if (rows.length <= 1) return;
   const [head, ...tail] = rows;
   rows = tail;
+  console.log('isEmpty head', isElementEmpty(head), head, el);
   if (isElementEmpty(head)) {
     head.remove();
   } else {