Skip to content

Commit

Permalink
Merge branch 'gnavinternal' of https://github.com/adobecom/milo into …
Browse files Browse the repository at this point in the history
…gnavinternal
  • Loading branch information
vgoodric committed May 7, 2024
2 parents f9f7ef8 + f78e8ed commit 02725c1
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 30 deletions.
26 changes: 0 additions & 26 deletions .github/workflows/email-release.yaml

This file was deleted.

7 changes: 7 additions & 0 deletions libs/blocks/mobile-app-banner/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Mobile App Banner

## Performance Impact
This block has a known issue of CLS and can add anywhere from 0.03 to 0.07 CLS (the CWV metric for CLS starts failing at 0.1).
Please make an informed decision based on the business requirements and current CLS on your page when using this block.

This CLS impact can be mitigated if branch banner is configured to load at the bottom of the page in branch dashboard.
6 changes: 2 additions & 4 deletions libs/features/personalization/personalization.js
Original file line number Diff line number Diff line change
Expand Up @@ -345,10 +345,8 @@ function getSelectedElement(selector, action, rootEl) {
}
if (checkSelectorType(selector) === 'fragment') {
try {
for (let i = 0; i <= 1; i += 1) {
const fragment = document.querySelector(`a[href*="${normalizePath(selector, !!i)}"]`);
if (fragment) return fragment.parentNode;
}
const fragment = document.querySelector(`a[href*="${normalizePath(selector, false)}"], a[href*="${normalizePath(selector, true)}"]`);
if (fragment) return fragment.parentNode;
return null;
} catch (e) {
return null;
Expand Down
2 changes: 2 additions & 0 deletions test/blocks/marketo/mocks/marketo-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,5 @@ export function createIntersectionObserver({ el, callback /* , once = true, opti
// fire immediately
callback(el, { target: el });
}

export const localizeLink = (href) => href;

0 comments on commit 02725c1

Please sign in to comment.