MWPW-135527 Move common validation and error handler in Floodgate AIO #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… actions Moved the common validation to FgAction and actions updated to refer to FgAction
raga-adbe-gh
requested review from
sukamat,
sirivuri,
Nethraasivakumar and
arshadparwaiz
arshadparwaiz
approved these changes
Sep 13, 2023
sukamat
reviewed
Sep 14, 2023
actions/FgAction.js
Outdated
| const logger = getAioLogger(); | ||
| const BAD_REQUEST_SC = 400; | ||
| const AUTH_FAILED_SC = 401; | ||
| const GEN_ERROR_SC = 401; |
There was a problem hiding this comment.
Should we set this to 500?
There was a problem hiding this comment.
Thank you @sukamat, As suggested updated to 500.
sukamat
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the common validation to FgAction and actions updated to refer to FgAction. Few initialization related to status is also moved to FgAction
Resolves: MWPW-135527