MWPW-134761 Authenticated Preview/Publish API calls for restricted sites #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the helix admin function out of utils to helixUtils. Updated preview/publish to pass the Authorization code, if the key is defined in config.
Below config to be added to .env
HELIX_ADMIN_API_KEYS={"cc": "<cc key>", "cc-pink": "<cc key>"}
Checked for below, With Preview Enabled (on CC / CC-Pink)
Non Protected Site (CC-Pink - No Key) - Preview passed
Protected Site (CC) with valid Key - Preview passed
Protected Site (CC) with Invalid/Missing Key - Preview failed and logged in xlsx
Preview/Publish is disabled back till the bulk API is fixed.
raga-adbe-gh
requested review from
sirivuri,
Nethraasivakumar,
arshadparwaiz and
sukamat
sukamat
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the helix admin function out of utils to helixUtils. Updated preview/publish to pass the Authorization code, if the key is defined in config.
Below config to be added to .env
HELIX_ADMIN_API_KEYS={"cc": "", "cc-pink": ""}
Checked for below, With Preview Enabled (on CC / CC-Pink)
Non Protected Site (CC-Pink - No Key) - Preview passed
Protected Site (CC) with valid Key - Preview passed
Protected Site (CC) with Invalid/Missing Key - Preview failed and logged in xlsx
Preview/Publish is disabled back till the bulk API is ready.
Resolves: MWPW-134761