MWPW-128690 Unit Tests (#93)

* Update README.md * MWPW-142865: Stage deploy script updated (#91) * .env template for easier setup and onboarding (#90) * Update README.md * .env template for easier setup and onboarding * remove temp change * MWPW-142865: Stage deploy script updated (#89) * Revert temp readme change * MWPW-128690 Unit Tests Unit Test Coverage for action helpers and utilities. Payload handling updated * Minor fixes * Sharepoint reference updated * Rename FgAction --------- Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Raghu A <[email protected]>
adobecom · Mar 19, 2024 · c4f457f · c4f457f
1 parent 69ba144
commit c4f457f
Show file tree

Hide file tree

Showing 40 changed files with 2,994 additions and 1,305 deletions.
diff --git a/actions/appConfig.js b/actions/appConfig.js
@@ -20,21 +20,22 @@ const { strToArray, strToBool, getAioLogger } = require('./utils');
 const UrlInfo = require('./urlInfo');
 
 // Max activation is 1hrs, set to 2hrs
-const MAX_ACTIVATION_TIME = 2 * 60 * 60 * 1000;
-const ENV_VAR_ACTIVATION_ID = '__OW_ACTIVATION_ID';
+const GRAPH_API = 'https://graph.microsoft.com/v1.0';
 
 /**
  * This store the Floodate configs.
  * Common Configs - Parameters like Batch
  */
 class AppConfig {
-    // set payload per activation
-    configMap = { payload: {} };
+    constructor(params) {
+        this.configMap = { payload: {} };
+        if (params) {
+            this.setAppConfig(params);
+        }
+    }
 
     setAppConfig(params) {
-        const payload = this.initPayload();
-        // Called during action start to cleanup old entries
-        this.removeOldPayload();
+        const payload = this.getPayload();
 
         // These are payload parameters
         // eslint-disable-next-line no-underscore-dangle
@@ -85,37 +86,8 @@ class AppConfig {
         };
     }
 
-    // Activation Payload Related
-    initPayload() {
-        this.configMap.payload[this.getPayloadKey()] = {
-            payloadAccessedOn: new Date().getTime()
-        };
-        return this.configMap.payload[this.getPayloadKey()];
-    }
-
-    getPayloadKey() {
-        return process.env[ENV_VAR_ACTIVATION_ID];
-    }
-
     getPayload() {
-        this.configMap.payload[this.getPayloadKey()].payloadAccessedOn = new Date().getTime();
-        return this.configMap.payload[this.getPayloadKey()];
-    }
-
-    removePayload() {
-        delete this.configMap.payload[this.getPayloadKey()];
-    }
-
-    /**
-     * Similar to LRU
-     */
-    removeOldPayload() {
-        const { payload } = this.configMap;
-        const payloadKeys = Object.keys(payload);
-        const leastTime = new Date().getTime();
-        payloadKeys
-            .filter((key) => payload[key]?.payloadAccessedOn < leastTime - MAX_ACTIVATION_TIME)
-            .forEach((key) => delete payload[key]);
+        return this.configMap.payload;
     }
 
     // Configs related methods
@@ -242,6 +214,74 @@ class AppConfig {
     getUserToken() {
         return this.getPayload().spToken;
     }
+
+    getSpConfig() {
+        if (!this.getUrlInfo().isValid()) {
+            return undefined;
+        }
+
+        const config = this.getConfig();
+
+        // get drive id if available
+        const { driveId, rootFolder, fgRootFolder } = this.getPayload();
+        const drive = driveId ? `/drives/${driveId}` : '/drive';
+
+        const baseURI = `${config.fgSite}${drive}/root:${rootFolder}`;
+        const fgBaseURI = `${config.fgSite}${drive}/root:${fgRootFolder}`;
+        const baseItemsURI = `${config.fgSite}${drive}/items`;
+        return {
+            api: {
+                url: GRAPH_API,
+                file: {
+                    get: { baseURI, fgBaseURI },
+                    download: { baseURI: `${config.fgSite}${drive}/items` },
+                    upload: {
+                        baseURI,
+                        fgBaseURI,
+                        method: 'PUT',
+                    },
+                    delete: {
+                        baseURI,
+                        fgBaseURI,
+                        method: 'DELETE',
+                    },
+                    update: {
+                        baseURI,
+                        fgBaseURI,
+                        method: 'PATCH',
+                    },
+                    createUploadSession: {
+                        baseURI,
+                        fgBaseURI,
+                        method: 'POST',
+                        payload: { '@microsoft.graph.conflictBehavior': 'replace' },
+                    },
+                    copy: {
+                        baseURI,
+                        fgBaseURI,
+                        method: 'POST',
+                        payload: { '@microsoft.graph.conflictBehavior': 'replace' },
+                    },
+                },
+                directory: {
+                    create: {
+                        baseURI,
+                        fgBaseURI,
+                        method: 'PATCH',
+                        payload: { folder: {} },
+                    },
+                },
+                excel: {
+                    get: { baseItemsURI },
+                    update: {
+                        baseItemsURI,
+                        method: 'POST',
+                    },
+                },
+                batch: { uri: `${GRAPH_API}/$batch` },
+            },
+        };
+    }
 }
 
-module.exports = new AppConfig();
+module.exports = AppConfig;
diff --git a/actions/batch.js b/actions/batch.js
@@ -17,7 +17,6 @@
  ************************************************************************* */
 
 const { getAioLogger } = require('./utils');
-const appConfig = require('./appConfig');
 
 const logger = getAioLogger();
 
@@ -41,7 +40,7 @@ class Batch {
         this.filesSdk = params.filesSdk;
         this.instancePath = params.instancePath;
         this.batchNumber = params?.batchNumber || 1;
-        this.maxFilesPerBatch = appConfig.getBatchConfig().maxFilesPerBatch;
+        this.maxFilesPerBatch = params?.maxFilesPerBatch || 200;
         this.batchPath = `${this.instancePath}/${FOLDER_PREFIX}_${this.batchNumber}`;
         this.batchInfoFile = `${this.batchPath}/${BATCH_INFO_FILE}`;
         this.resultsFile = `${this.batchPath}/${RESULTS_FILE}`;
@@ -85,7 +84,6 @@ class Batch {
         if (!this.filesSdk || !this.batchFiles?.length) return;
         const dataStr = JSON.stringify(this.batchFiles);
         await this.filesSdk.write(this.batchInfoFile, dataStr);
-        this.batchInfoFile = [];
     }
 
     async getFiles() {

diff --git a/actions/batchManager.js b/actions/batchManager.js
@@ -17,7 +17,6 @@
  ************************************************************************* */
 const filesLib = require('@adobe/aio-lib-files');
 const Batch = require('./batch');
-const appConfig = require('./appConfig');
 const { getAioLogger } = require('./utils');
 
 const logger = getAioLogger();
@@ -37,6 +36,8 @@ const logger = getAioLogger();
  *   There needs to be enhacement to handle this within this e.g. Batch execution stargergy should be implemented.
  */
 class BatchManager {
+    batchConfig = null;
+
     filesSdk = null;
 
     instanceData = { lastBatch: '', dtls: { batchesInfo: [] } };
@@ -50,7 +51,8 @@ class BatchManager {
     constructor(params) {
         this.params = params || {};
         this.batches = [];
-        this.batchFilesPath = appConfig.getBatchConfig()?.batchFilesPath;
+        this.batchConfig = params.batchConfig;
+        this.batchFilesPath = this.batchConfig.batchFilesPath;
         this.key = params.key;
         this.bmPath = `${this.batchFilesPath}/${this.key}`;
         this.bmTracker = `${this.bmPath}/tracker.json`;
@@ -82,7 +84,8 @@ class BatchManager {
                 ...this.params,
                 filesSdk: this.filesSdk,
                 instancePath: this.instancePath,
-                batchNumber: this.currentBatchNumber
+                batchNumber: this.currentBatchNumber,
+                maxFilesPerBatch: this.batchConfig.maxFilesPerBatch
             });
             this.batches.push(this.currentBatch);
         }
@@ -106,7 +109,8 @@ class BatchManager {
      * Structure
      * {
      *   instanceKeys: [_milo_pink],
-     *   '_milo_pink': {done: <true>, proceed: <true>}
+     *   '_milo_pink': {done: <true>, proceed: <true>},
+     * *  '_bacom_pink': {done: <true>, proceed: <true>},
      * }
      */
     async readBmTracker() {
@@ -275,7 +279,8 @@ class BatchManager {
         this.currentBatch = new Batch({
             filesSdk: this.filesSdk,
             instancePath: this.instancePath,
-            batchNumber: this.currentBatchNumber
+            batchNumber: this.currentBatchNumber,
+            maxFilesPerBatch: this.batchConfig.maxFilesPerBatch
         });
         this.batches.push(this.currentBatch);
         this.instanceData.lastBatch = this.currentBatchNumber;

diff --git a/actions/config.js b/actions/config.js