Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-160129: DC Fill and Sign: Stage page use prod library #853

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

joaquinrivero
Copy link
Collaborator

@joaquinrivero joaquinrivero commented Oct 15, 2024

Copy link

aem-code-sync bot commented Oct 15, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (2b919fe) to head (d727996).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #853   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files          48       48           
  Lines        6091     6092    +1     
=======================================
+ Hits         5182     5183    +1     
  Misses        909      909           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

aem-code-sync bot commented Oct 15, 2024

Page Scores Audits Google
📱 /acrobat/online/test/sign-pdf-projectunity PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /acrobat/online/test/sign-pdf-projectunity PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

acrobat/scripts/utils.js Outdated Show resolved Hide resolved
acrobat/scripts/utils.js Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/order> reported by reviewdog 🐶
../../acrobat/scripts/utils import should occur after import of @esm-bundle/chai

import { setLibs, getLibs } from '../../acrobat/scripts/utils';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getLibs' is defined but never used.

import { setLibs, getLibs } from '../../acrobat/scripts/utils';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../acrobat/scripts/utils"

import { setLibs, getLibs } from '../../acrobat/scripts/utils';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'sinon' is defined but never used.

import * as sinon from 'sinon';

@TsayAdobe TsayAdobe merged commit 1009050 into stage Oct 21, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants