-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-160129: DC Fill and Sign: Stage page use prod library #853
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #853 +/- ##
=======================================
Coverage 85.07% 85.07%
=======================================
Files 48 48
Lines 6091 6092 +1
=======================================
+ Hits 5182 5183 +1
Misses 909 909 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/order> reported by reviewdog 🐶../../acrobat/scripts/utils
import should occur after import of @esm-bundle/chai
Line 1 in d727996
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getLibs' is defined but never used.
Line 1 in d727996
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../acrobat/scripts/utils"
Line 1 in d727996
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'sinon' is defined but never used.
Line 2 in d727996
import * as sinon from 'sinon'; |
Resolves: MWPW-160129
Test URL: