Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-158122: Verb Widget Analytics #816

Merged
merged 3 commits into from
Sep 19, 2024
Merged

MWPW-158122: Verb Widget Analytics #816

merged 3 commits into from
Sep 19, 2024

Conversation

Blainegunn
Copy link
Collaborator

Resolves : MWPW-158122

Outstanding Events and eVars

Do we need these?
Evars post_evar6
Evars mobile_id
Evars ref_type
Evars ref_domain
Evars referrer
Evars visit_ref_domain
Evars visit_ref_type
Evars visit_referrer

Need Help from Unity Team
Evar v183 PDF document type
Evar (v12) Entitlement Id
Evar v184 PDF file size
Evar v195 File type
Evar v198 File extension

Page: Upload Error acrobat:verb-fillsign:error:max_page_count
Page: Upload Error acrobat:verb-fillsign:error:page_count_missing_from_metadata_api

???
Page: Upload Error acrobat:verb-fillsign:error
Page: Upload Error acrobat:verb-fillsign:error:403

Copy link

aem-code-sync bot commented Sep 18, 2024

This branch is ignored due to an invalid branch name. Branch names must:

  • begin and end with alphanumeric characters
  • not contain consecutive hyphens

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 14.74359% with 133 lines in your changes missing coverage. Please review.

Project coverage is 69.22%. Comparing base (8bce0c7) to head (86776f3).

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 10.00% 72 Missing ⚠️
acrobat/scripts/alloy/verb-widget.js 19.73% 61 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #816      +/-   ##
==========================================
- Coverage   70.51%   69.22%   -1.30%     
==========================================
  Files          47       47              
  Lines        7064     7177     +113     
==========================================
- Hits         4981     4968      -13     
- Misses       2083     2209     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquinrivero joaquinrivero changed the title MWPW-158122 MWPW-158122: Acom Widget Analytics Sep 19, 2024
@joaquinrivero joaquinrivero changed the title MWPW-158122: Acom Widget Analytics MWPW-158122: Verb Widget Analytics Sep 19, 2024

// Errors, Analytics & Logging
window.addEventListener('unity:show-error-toast', (e) => {
console.log(`⛔️ Error Code - ${e.detail?.code}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

});
}

// const ce = (new CustomEvent('unity:show-error-toast', { detail: { code: 'only_accept_one_file', message: 'Error message' } }));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 130. Maximum allowed is 100.

export default function init(eventName, verb) {
console.log(`📡 Event Name - acrobat:verb-${verb}:${eventName}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

@Blainegunn
Copy link
Collaborator Author

merging to test

@Blainegunn Blainegunn merged commit 46ba26b into stage Sep 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants