Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-156372 #814

Merged
merged 1 commit into from
Sep 18, 2024
Merged

MWPW-156372 #814

merged 1 commit into from
Sep 18, 2024

Conversation

Blainegunn
Copy link
Collaborator

Resolves : MWPW-156372

Copy link

aem-code-sync bot commented Sep 18, 2024

This branch is ignored due to an invalid branch name. Branch names must:

  • begin and end with alphanumeric characters
  • not contain consecutive hyphens

@Blainegunn Blainegunn added this to the 0.2439 milestone Sep 18, 2024
@Blainegunn Blainegunn merged commit 8bce0c7 into stage Sep 18, 2024
6 of 7 checks passed
Comment on lines 1 to 2

import LIMITS from './limits.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
Too many blank lines at the beginning of file. Max of 0 allowed.

Suggested change
import LIMITS from './limits.js';
import LIMITS from './limits.js';

@@ -73,19 +49,6 @@
shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.52%. Comparing base (1366533) to head (e36d111).
Report is 2 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #814      +/-   ##
==========================================
+ Coverage   70.43%   70.52%   +0.08%     
==========================================
  Files          47       47              
  Lines        7107     7064      -43     
==========================================
- Hits         5006     4982      -24     
+ Misses       2101     2082      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants