DC Milo 0.2438 #810

Blainegunn · 2024-09-17T19:35:18Z

Release Notes: DC Milo 0.2438

Skip failing unit tests

MWPW-158031: Unit tests and block fixes

…ers-verb-widget Implemented redirection for signed in users for verb-widget. Refactor

MWPW-157036: Nonprofit form with api integration

MWPW-158520: Reducing sample rate for CSP

DCXY-25692 log cause.message from wrapped exception, if present

Update Table Integration test baseline images

aem-code-sync · 2024-09-17T19:35:23Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

c926fbb ❌ (latest)
2d7a325 ❌
dff25a2 ❌
761ca97 ❌
ab9ab8b ❌
f899819 ❌
50b6069 ❌
427fdc1 ❌
7210c12 ❌
69fc267 ❌
2916da0 ❌
4d21814 ❌
79d85e9 ❌
3ac660b ❌
ac9c508 ❌
0901696 ❌
4a1aa48 ❌
f40e52b ❌
51bc0ed ❌
e4a65d2 ❌
199657d ❌
bcd0a50 ❌
842ddb0 ❌
0d38819 ❌
c862b9b ❌
b9e060f ❌
0a49c9f ❌
367eb3a ❌
cfe4535 ❌
5ec1a63 ❌

codecov-commenter · 2024-09-17T19:36:38Z

Codecov Report

Attention: Patch coverage is 27.78448% with 1796 lines in your changes missing coverage. Please review.

Project coverage is 70.45%. Comparing base (9a26748) to head (5b63036).
Report is 154 commits behind head on main.

Files with missing lines	Patch %	Lines
acrobat/blocks/nonprofit/nonprofit.js	0.00%	805 Missing ⚠️
acrobat/blocks/nonprofit/constants.js	0.00%	427 Missing ⚠️
acrobat/blocks/nonprofit/select.js	0.00%	256 Missing ⚠️
acrobat/blocks/unity/unity.js	0.00%	113 Missing ⚠️
acrobat/blocks/verb-widget/verb-widget.js	41.08%	109 Missing ⚠️
acrobat/scripts/reactiveStore.js	0.00%	50 Missing ⚠️
acrobat/scripts/alloy/verb-widget.js	3.22%	30 Missing ⚠️
acrobat/blocks/rnr/rnr.js	99.14%	4 Missing ⚠️
acrobat/scripts/utils.js	90.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #810       +/-   ##
===========================================
- Coverage   93.81%   70.45%   -23.36%     
===========================================
  Files          40       47        +7     
  Lines        4944     7109     +2165     
===========================================
+ Hits         4638     5009      +371     
- Misses        306     2100     +1794

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
Promise.resolve() is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 28 in 5b63036

Promise.resolve(

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 29 to 30 in 5b63036

    
             fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) 
        
           ),

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URL is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 34 in 5b63036

window.location = new URL('https://www.adobe.com');

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'widget' is assigned a value but never used.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 36 in 5b63036

const widget = await init(block);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'init' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 36 in 5b63036

const widget = await init(block);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 39 in 5b63036

expect(launcher.getAttribute('src')).toMatch(/^https:\/\/acrobat.adobe.com\//);

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'fetchUrl' is assigned a value but never used.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 50 in 5b63036

let fetchUrl = '';

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
fetch is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 51 in 5b63036

window.fetch = jest.fn((url) => {

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'jest' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 51 in 5b63036

window.fetch = jest.fn((url) => {

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
Promise.resolve() is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 53 in 5b63036

return Promise.resolve({

🚫 [eslint] <implicit-arrow-linebreak> _{reported by reviewdog 🐶}
Expected no linebreak before this expression.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 56 in 5b63036

Promise.resolve(

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
Promise.resolve() is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 56 in 5b63036

Promise.resolve(

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 57 to 58 in 5b63036

    
             fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) 
        
           ),

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URL is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 62 in 5b63036

window.location = new URL(`https://${hostname}`);

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'widget' is assigned a value but never used.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 64 in 5b63036

const widget = await init(block);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'init' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 64 in 5b63036

const widget = await init(block);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 67 in 5b63036

    
           expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//);

🚫 [eslint] <no-trailing-spaces> _{reported by reviewdog 🐶}
Trailing spaces not allowed.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 67 in 5b63036

    
           expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//);

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
fetch is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 71 in 5b63036

window.fetch = jest.fn(() =>

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'jest' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 71 in 5b63036

window.fetch = jest.fn(() =>

🚫 [eslint] <implicit-arrow-linebreak> _{reported by reviewdog 🐶}
Expected no linebreak before this expression.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 72 in 5b63036

Promise.resolve({

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
Promise.resolve() is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 72 in 5b63036

Promise.resolve({

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break after this opening brace.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 72 in 5b63036

Promise.resolve({

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break before this closing brace.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 74 in 5b63036

})

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 74 to 75 in 5b63036

🚫 [eslint] <function-paren-newline> _{reported by reviewdog 🐶}
Unexpected newline before ')'.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 75 in 5b63036

);

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URL is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 77 in 5b63036

window.location = new URL('https://www.adobe.com');

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'widget' is assigned a value but never used.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 79 in 5b63036

const widget = await init(block);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'init' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 79 in 5b63036

const widget = await init(block);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 80 in 5b63036

expect(document.querySelector('#CID').children).toHaveLength(3);

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
fetch is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 90 in 5b63036

window.fetch = jest.fn((url) =>

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'jest' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 90 in 5b63036

window.fetch = jest.fn((url) =>

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'url' is defined but never used.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 90 in 5b63036

window.fetch = jest.fn((url) =>

🚫 [eslint] <implicit-arrow-linebreak> _{reported by reviewdog 🐶}
Expected no linebreak before this expression.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 91 in 5b63036

Promise.resolve({

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
Promise.resolve() is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 91 in 5b63036

Promise.resolve({

🚫 [eslint] <implicit-arrow-linebreak> _{reported by reviewdog 🐶}
Expected no linebreak before this expression.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 94 in 5b63036

Promise.resolve(

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
Promise.resolve() is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 94 in 5b63036

Promise.resolve(

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 95 to 96 in 5b63036

    
             fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) 
        
           ),

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 97 to 98 in 5b63036

🚫 [eslint] <function-paren-newline> _{reported by reviewdog 🐶}
Unexpected newline before ')'.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 98 in 5b63036

);

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break after this opening brace.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 99 in 5b63036

window.adobeIMS = {

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'jest' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 100 in 5b63036

isSignedInUser: jest.fn(() => true)

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 100 to 101 in 5b63036

    
             isSignedInUser: jest.fn(() => true) 
        
           };

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break before this closing brace.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 101 in 5b63036

};

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URL is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 103 in 5b63036

window.location = new URL(`https://${hostname}`);

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'widget' is assigned a value but never used.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 105 in 5b63036

const widget = await init(block);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'init' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 105 in 5b63036

const widget = await init(block);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 107 in 5b63036

expect(window.location).toMatch(/^https:\/\/www.adobe.com\/go\/acrobat-/);

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
fetch is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 115 in 5b63036

window.fetch = jest.fn((url) =>

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'jest' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 115 in 5b63036

window.fetch = jest.fn((url) =>

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'url' is defined but never used.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 115 in 5b63036

window.fetch = jest.fn((url) =>

🚫 [eslint] <implicit-arrow-linebreak> _{reported by reviewdog 🐶}
Expected no linebreak before this expression.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 116 in 5b63036

Promise.resolve({

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
Promise.resolve() is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 116 in 5b63036

Promise.resolve({

🚫 [eslint] <implicit-arrow-linebreak> _{reported by reviewdog 🐶}
Expected no linebreak before this expression.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 119 in 5b63036

Promise.resolve(

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
Promise.resolve() is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 119 in 5b63036

Promise.resolve(

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 120 to 121 in 5b63036

    
             fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) 
        
           ),

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 122 to 123 in 5b63036

🚫 [eslint] <function-paren-newline> _{reported by reviewdog 🐶}
Unexpected newline before ')'.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 123 in 5b63036

);

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break after this opening brace.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 124 in 5b63036

window.adobeIMS = {

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'jest' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 125 in 5b63036

isSignedInUser: jest.fn(() => true)

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 125 to 126 in 5b63036

    
             isSignedInUser: jest.fn(() => true) 
        
           };

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break before this closing brace.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 126 in 5b63036

};

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URL is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 128 in 5b63036

window.location = new URL(`https://${hostname}`);

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'widget' is assigned a value but never used.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 130 in 5b63036

const widget = await init(block);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'init' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 130 in 5b63036

const widget = await init(block);

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URL is not supported in op_mini all

dc/test/scripts/utils.jest.js

Lines 14 to 16 in 5b63036

    
           window.location = new URL( 
        
             'https://www.adobe.com' 
        
           );

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/scripts/utils.jest.js

Lines 15 to 16 in 5b63036

    
             'https://www.adobe.com' 
        
           );

🚫 [eslint] <no-trailing-spaces> _{reported by reviewdog 🐶}
Trailing spaces not allowed.

dc/test/scripts/utils.jest.js

Line 16 in 5b63036

);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'setLibs' is not defined.

dc/test/scripts/utils.jest.js

Line 17 in 5b63036

const libs = setLibs('/libs');

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

dc/test/scripts/utils.jest.js

Line 18 in 5b63036

expect(libs).toBe('/libs');

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

dc/test/scripts/utils.jest.js

Line 19 in 5b63036

expect(getLibs()).toBe('/libs');

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'getLibs' is not defined.

dc/test/scripts/utils.jest.js

Line 19 in 5b63036

expect(getLibs()).toBe('/libs');

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URL is not supported in op_mini all

dc/test/scripts/utils.jest.js

Lines 24 to 26 in 5b63036

    
           window.location = new URL( 
        
             'https://www.stage.adobe.com' 
        
           );

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/scripts/utils.jest.js

Lines 25 to 26 in 5b63036

    
             'https://www.stage.adobe.com' 
        
           );

🚫 [eslint] <no-trailing-spaces> _{reported by reviewdog 🐶}
Trailing spaces not allowed.

dc/test/scripts/utils.jest.js

Line 26 in 5b63036

);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'setLibs' is not defined.

dc/test/scripts/utils.jest.js

Line 27 in 5b63036

const libs = setLibs('/libs');

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

dc/test/scripts/utils.jest.js

Line 28 in 5b63036

expect(libs).toBe('https://www.adobe.com/libs');

🚫 [eslint] <no-trailing-spaces> _{reported by reviewdog 🐶}
Trailing spaces not allowed.

dc/test/scripts/utils.jest.js

Line 29 in 5b63036

});

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URL is not supported in op_mini all

dc/test/scripts/utils.jest.js

Lines 33 to 35 in 5b63036

    
           window.location = new URL( 
        
             'https://www.stage.adobe.com?milolibs=local' 
        
           );

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/scripts/utils.jest.js

Lines 34 to 35 in 5b63036

    
             'https://www.stage.adobe.com?milolibs=local' 
        
           );

🚫 [eslint] <no-trailing-spaces> _{reported by reviewdog 🐶}
Trailing spaces not allowed.

dc/test/scripts/utils.jest.js

Line 35 in 5b63036

);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'setLibs' is not defined.

dc/test/scripts/utils.jest.js

Line 36 in 5b63036

const libs = setLibs('/libs');

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

dc/test/scripts/utils.jest.js

Line 37 in 5b63036

expect(libs).toBe('http://localhost:6456/libs');

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URL is not supported in op_mini all

dc/test/scripts/utils.jest.js

Lines 42 to 44 in 5b63036

    
           window.location = new URL( 
        
             'https://www.stage.adobe.com?milolibs=main--milo--tsayadobe' 
        
           );

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/scripts/utils.jest.js

Lines 43 to 44 in 5b63036

    
             'https://www.stage.adobe.com?milolibs=main--milo--tsayadobe' 
        
           );

🚫 [eslint] <no-trailing-spaces> _{reported by reviewdog 🐶}
Trailing spaces not allowed.

dc/test/scripts/utils.jest.js

Line 44 in 5b63036

);

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'setLibs' is not defined.

dc/test/scripts/utils.jest.js

Line 45 in 5b63036

const libs = setLibs('/libs');

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

dc/test/scripts/utils.jest.js

Line 46 in 5b63036

expect(libs).toBe('https://main--milo--tsayadobe.hlx.page/libs');

🚫 [eslint] <no-trailing-spaces> _{reported by reviewdog 🐶}
Trailing spaces not allowed.

dc/test/scripts/utils.jest.js

Line 47 in 5b63036

});

github-actions · 2024-09-17T19:37:40Z

acrobat/blocks/nonprofit/nonprofit.js

+  )
+    .then((response) => response.json())
+    .then((result) => {
+      console.log(result);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-17T19:37:40Z

acrobat/blocks/nonprofit/nonprofit.js

+      organizationsStore.update(result.data);
+    })
+    .catch((error) => {
+      console.log(error);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-17T19:37:40Z

acrobat/blocks/nonprofit/nonprofit.js

+  })
+    .then((response) => response.json())
+    .then((result) => {
+      console.log(result);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-17T19:37:40Z

acrobat/blocks/nonprofit/nonprofit.js

+      organizationsStore.update((prev) => [...prev, ...result.data]);
+    })
+    .catch((error) => {
+      console.log(error);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-17T19:37:41Z

acrobat/blocks/nonprofit/nonprofit.js

+  })
+    .then((response) => response.json())
+    .then((result) => {
+      console.log(result);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-17T19:37:41Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

@@ -3,9 +3,9 @@
 */
 import path from 'path';
 import fs from 'fs';
-import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb';
+//import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb';


🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

Suggested change

//import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb';

// import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb';

github-actions · 2024-09-17T19:37:41Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

@@ -131,5 +131,5 @@
    window.dispatchEvent(new CustomEvent('IMS:Ready'));
    // Issue with jest and window.location
    //expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/);


🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

Suggested change

//expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/);

// expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/);

github-actions · 2024-09-17T19:37:41Z

test/scripts/utils.jest.js

@@ -1,9 +1,9 @@
 /**
 * @jest-environment jsdom
 */
-import { setLibs, getLibs } from '../../acrobat/scripts/utils';
+//import { setLibs, getLibs } from '../../acrobat/scripts/utils';


🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

Suggested change

//import { setLibs, getLibs } from '../../acrobat/scripts/utils';

// import { setLibs, getLibs } from '../../acrobat/scripts/utils';

github-actions · 2024-09-17T19:37:42Z

test/scripts/utils.jest.js


-describe('Test utils.js', () => {
+describe.skip('Test utils.js', () => {
  it('tests setLibs', async () => {
    const libs = setLibs('/libs');


🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'setLibs' is not defined.

github-actions · 2024-09-17T19:37:42Z

test/scripts/utils.jest.js


-describe('Test utils.js', () => {
+describe.skip('Test utils.js', () => {
  it('tests setLibs', async () => {
    const libs = setLibs('/libs');
    expect(libs).toBe('https://main--milo--adobecom.hlx.page/libs');


🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'expect' is not defined.

github-actions · 2024-09-17T19:37:44Z

acrobat/blocks/unity/unity.js

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URLSearchParams is not supported in op_mini all

dc/acrobat/blocks/unity/unity.js

Line 101 in 5b63036

const branch = new URLSearchParams(window.location.search).get('unitylibs') || 'main';

github-actions · 2024-09-17T19:37:45Z

acrobat/scripts/utils.js

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URLSearchParams is not supported in op_mini all

dc/acrobat/scripts/utils.js

Line 28 in 5b63036

const branch = new URLSearchParams(search).get('milolibs') || 'main';

github-actions · 2024-09-17T19:37:46Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Lines 12 to 13 in 5b63036

'utf8'

);

github-actions · 2024-09-17T19:37:47Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'jest' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 14 in 5b63036

window.performance.mark = jest.fn();

github-actions · 2024-09-17T19:37:48Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'jest' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 18 in 5b63036

jest.clearAllMocks();

github-actions · 2024-09-17T19:37:48Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'fetchUrl' is assigned a value but never used.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 22 in 5b63036

let fetchUrl = '';

github-actions · 2024-09-17T19:37:49Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
fetch is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 23 in 5b63036

window.fetch = jest.fn((url) => {

github-actions · 2024-09-17T19:37:50Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'jest' is not defined.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 23 in 5b63036

window.fetch = jest.fn((url) => {

github-actions · 2024-09-17T19:37:51Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
Promise.resolve() is not supported in op_mini all

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 25 in 5b63036

return Promise.resolve({

github-actions · 2024-09-17T19:37:52Z

test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

🚫 [eslint] <implicit-arrow-linebreak> _{reported by reviewdog 🐶}
Expected no linebreak before this expression.

dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js

Line 28 in 5b63036

Promise.resolve(

st-angelo-adobe and others added 30 commits August 27, 2024 15:22

Rough UI nonprofit

5ec1a63

test sandbox init

cfe4535

stepper changes

367eb3a

font name

0a49c9f

Addging, to #CID Adobe Clean

b9e060f

Override general divs

c862b9b

Merge branch 'stage' into heading-font

0d38819

optimizing CSS selectors for #CID elements

842ddb0

Linting fix

bcd0a50

Use device type in EW

199657d

Update headers

e4a65d2

Add teste

51bc0ed

Update unity.js

f40e52b

Update unity.css

4a1aa48

Update unity.js

0901696

Update unity.js

ac9c508

MWPW-158031: Unit tests and block fixes

3ac660b

Update utils.js

79d85e9

implemented integration test for table block

4d21814

Merge branch 'stage' into heading-font

2916da0

Fix DRY

69fc267

Skip tests

7210c12

Fix unit tests

427fdc1

Merge pull request #797 from adobecom/testfix

50b6069

Skip failing unit tests

Merge branch 'stage' into ewmobile

f899819

merged with stage

ab9ab8b

test adjustments

761ca97

Merge pull request #792 from adobecom/MWPW-158031

dff25a2

MWPW-158031: Unit tests and block fixes

MWPW-158176: Production URL and cleanup

2d7a325

Merge branch 'stage' into unityblock

c926fbb

Blainegunn and others added 15 commits September 16, 2024 13:05

Merge pull request #800 from adobecom/mwpw-154530-redirect-sign-in-us…

ea9e421

…ers-verb-widget Implemented redirection for signed in users for verb-widget. Refactor

log cause.message, if present

ab41d65

Merge branch 'stage' into dc-hosted-error-detail

0862d85

review suggestion

f681555

eslint ignore

25043e3

Integration with the nonprofit service

925c1f9

removed dump file

73d3d10

Merge pull request #808 from adobecom/MWPW-157036

e66b687

MWPW-157036: Nonprofit form with api integration

Merge branch 'stage' into MWPW-158476

e9809ee

Reducing sample rate for CSP

050e7cc

Merge pull request #809 from adobecom/MWPW-158520

55154ce

MWPW-158520: Reducing sample rate for CSP

Merge branch 'stage' into dc-hosted-error-detail

fca00e9

Merge pull request #807 from adobecom/dc-hosted-error-detail

e14e801

DCXY-25692 log cause.message from wrapped exception, if present

Merge branch 'stage' into MWPW-158476

c913d7d

Merge pull request #806 from adobecom/MWPW-158476

5b63036

Update Table Integration test baseline images

Blainegunn merged commit 1951099 into main Sep 17, 2024
12 of 16 checks passed

github-actions bot reviewed Sep 17, 2024

View reviewed changes

aem-code-sync bot temporarily deployed to clearcache September 18, 2024 21:04 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DC Milo 0.2438 #810

DC Milo 0.2438 #810

Blainegunn commented Sep 17, 2024

aem-code-sync bot commented Sep 17, 2024

codecov-commenter commented Sep 17, 2024

github-actions bot left a comment

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

github-actions bot Sep 17, 2024

	fs.readFileSync(path.resolve(__dirname, './mocks/widget.html'))
	),

	window.location = new URL(
	'https://www.stage.adobe.com?milolibs=local'
	);

	window.location = new URL(
	'https://www.stage.adobe.com?milolibs=main--milo--tsayadobe'
	);

	//import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb';
	// import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb';

	//expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/);
	// expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/);

	//import { setLibs, getLibs } from '../../acrobat/scripts/utils';
	// import { setLibs, getLibs } from '../../acrobat/scripts/utils';

DC Milo 0.2438 #810

DC Milo 0.2438 #810

Conversation

Blainegunn commented Sep 17, 2024

aem-code-sync bot commented Sep 17, 2024

codecov-commenter commented Sep 17, 2024

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment