Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157776 Prompt Card Block #805

Open
wants to merge 7 commits into
base: stage
Choose a base branch
from
Open

MWPW-157776 Prompt Card Block #805

wants to merge 7 commits into from

Conversation

TsayAdobe
Copy link
Collaborator

@TsayAdobe TsayAdobe commented Sep 16, 2024

  • The prompt card block is for a one-off prompt card
  • The variation template block is for a group of prompt cards that have some common settings. The common settings can be in a template.
  • The variation template, group block is for a group of prompt cards that have some common settings. It can be authored in a more compact fashion.
  • Unit tests have 100% coverage

Resolves: MWPW-157776

Test URLs:
https://promptcard--dc--adobecom.hlx.live/drafts/tsay/prompt-cards?martech=off
https://promptcard--dc--adobecom.hlx.live/drafts/tsay/prompt-cards-template?martech=off
https://promptcard--dc--adobecom.hlx.live/drafts/tsay/prompt-cards-template-group?martech=off

Please go to the Word docs to see the authoring experience.

Copy link

aem-code-sync bot commented Sep 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.99%. Comparing base (ea9e421) to head (922996f).
Report is 25 commits behind head on stage.

Additional details and impacted files
@@             Coverage Diff             @@
##            stage     #805       +/-   ##
===========================================
- Coverage   89.91%   70.99%   -18.92%     
===========================================
  Files          43       48        +5     
  Lines        5570     7179     +1609     
===========================================
+ Hits         5008     5097       +89     
- Misses        562     2082     +1520     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants