Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Unityblock #791

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Optimize Unityblock #791

merged 6 commits into from
Sep 11, 2024

Conversation

aishwaryamathuria
Copy link
Contributor

@aishwaryamathuria aishwaryamathuria commented Sep 9, 2024

Since we do not need the widget styles in acrobat and the only style required is to make unity block hidden.. adding that style to unity.css and removing the call to styles.css in unity.

Before: https://main--dc--adobecom.hlx.page/drafts/mathuria/acrobatfillsign?unitylibs=stage&martech=off
After: https://unityblock--dc--adobecom.hlx.page/drafts/mathuria/acrobatfillsign?unitylibs=dcredirect&martech=off

Copy link

aem-code-sync bot commented Sep 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 9, 2024

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URLSearchParams is not supported in op_mini all

const branch = new URLSearchParams(window.location.search).get('unitylibs') || 'main';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URLSearchParams is not supported in op_mini all

const branch = new URLSearchParams(search).get('milolibs') || 'main';

@Blainegunn Blainegunn merged commit 59f7ed8 into stage Sep 11, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants