-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Unityblock #791
Optimize Unityblock #791
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URLSearchParams is not supported in op_mini all
dc/acrobat/blocks/unity/unity.js
Line 101 in 0901696
const branch = new URLSearchParams(window.location.search).get('unitylibs') || 'main'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URLSearchParams is not supported in op_mini all
Line 28 in 79d85e9
const branch = new URLSearchParams(search).get('milolibs') || 'main'; |
Since we do not need the widget styles in acrobat and the only style required is to make unity block hidden.. adding that style to unity.css and removing the call to styles.css in unity.
Before: https://main--dc--adobecom.hlx.page/drafts/mathuria/acrobatfillsign?unitylibs=stage&martech=off
After: https://unityblock--dc--adobecom.hlx.page/drafts/mathuria/acrobatfillsign?unitylibs=dcredirect&martech=off