Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-155563 #790

Merged
merged 1 commit into from
Sep 6, 2024
Merged

MWPW-155563 #790

merged 1 commit into from
Sep 6, 2024

Conversation

Blainegunn
Copy link
Collaborator

Resolves : MWPW-155563

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Sep 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@Blainegunn Blainegunn merged commit 1c7776b into stage Sep 6, 2024
5 of 8 checks passed
@Blainegunn Blainegunn added this to the 0.2437 milestone Sep 6, 2024
github-actions[bot]
github-actions bot reviewed Sep 6, 2024
View reviewed changes
acrobat/blocks/verb-widget/verb-widget.js
// verbAnalytics('error:step01:file-too-large', verb);
// handleError(err, errTxt, 'verb-widget-error-large', LIMITS[verb].maxFileSizeFriendly);
// }
// };

const setDraggingClass = (widget, shouldToggle) => {
shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.

github-actions[bot]
github-actions bot reviewed Sep 6, 2024
View reviewed changes
acrobat/blocks/unity/unity.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URLSearchParams is not supported in op_mini all

dc/acrobat/blocks/unity/unity.js

Line 103 in 8f6e651

const branch = new URLSearchParams(window.location.search).get('unitylibs') || 'main';

github-actions[bot]
github-actions bot reviewed Sep 6, 2024
View reviewed changes
acrobat/blocks/unity/unity.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise is not supported in op_mini all

dc/acrobat/blocks/unity/unity.js

Lines 113 to 115 in 8f6e651

const stylePromise = new Promise((resolve) => {
loadStyle(`${unitylibs}/core/styles/styles.css`, resolve);
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2437
Development

Successfully merging this pull request may close these issues.
1 participant
@Blainegunn