Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157507 #789

Merged
merged 2 commits into from
Sep 6, 2024
Merged

MWPW-157507 #789

merged 2 commits into from
Sep 6, 2024

Conversation

Blainegunn
Copy link
Collaborator

@Blainegunn Blainegunn commented Sep 5, 2024

Resolves : MWPW-157507
Changed name of acom-widget to verb-widget

@Blainegunn Blainegunn added this to the 0.2437 milestone Sep 5, 2024
Copy link

aem-code-sync bot commented Sep 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 106. Maximum allowed is 100.

// console.log('Blob Viewer URL:', `<a href="${blobViewerUrl}" target="_blank">View PDF</a>`);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'file' is defined but never used.

[...ev.dataTransfer.files].forEach((file, i) => {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'i' is defined but never used.

[...ev.dataTransfer.files].forEach((file, i) => {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.

shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging');

@Blainegunn
Copy link
Collaborator Author

@aishwaryamathuria @Ruchika4 @sanjayms01
Please note we've changed the name of our marquee from acom-widget to verb-widget as well as all children elements.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.97297% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.79%. Comparing base (9eb351d) to head (a74cd26).

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 72.97% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #789      +/-   ##
==========================================
+ Coverage   85.77%   85.79%   +0.01%     
==========================================
  Files          42       42              
  Lines        5464     5464              
==========================================
+ Hits         4687     4688       +1     
+ Misses        777      776       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayms01
Copy link

sanjayms01 commented Sep 6, 2024

@aishwaryamathuria @Ruchika4 @sanjayms01 Please note we've changed the name of our marquee from acom-widget to verb-widget as well as all children elements.

Thanks @Blainegunn for the heads up! I'll work to map things out accordingly on the Unity end.

@Blainegunn Blainegunn merged commit 1e00625 into stage Sep 6, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants