-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-157507 #789
MWPW-157507 #789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'file' is defined but never used.
dc/acrobat/blocks/verb-widget/verb-widget.js
Line 122 in 7d59109
[...ev.dataTransfer.files].forEach((file, i) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'i' is defined but never used.
dc/acrobat/blocks/verb-widget/verb-widget.js
Line 122 in 7d59109
[...ev.dataTransfer.files].forEach((file, i) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.
dc/acrobat/blocks/verb-widget/verb-widget.js
Line 129 in 7d59109
shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging'); |
@aishwaryamathuria @Ruchika4 @sanjayms01 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #789 +/- ##
==========================================
+ Coverage 85.77% 85.79% +0.01%
==========================================
Files 42 42
Lines 5464 5464
==========================================
+ Hits 4687 4688 +1
+ Misses 777 776 -1 ☔ View full report in Codecov by Sentry. |
Thanks @Blainegunn for the heads up! I'll work to map things out accordingly on the Unity end. |
Resolves : MWPW-157507
Changed name of
acom-widget
toverb-widget