-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sending analytics for scenario where multiple files are selected #787
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #787 +/- ##
==========================================
- Coverage 85.89% 85.85% -0.04%
==========================================
Files 42 42
Lines 5458 5459 +1
==========================================
- Hits 4688 4687 -1
- Misses 770 772 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'file' is defined but never used.
dc/acrobat/blocks/acom-widget/acom-widget.js
Line 122 in b49ee54
[...ev.dataTransfer.files].forEach((file, i) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'i' is defined but never used.
dc/acrobat/blocks/acom-widget/acom-widget.js
Line 122 in b49ee54
[...ev.dataTransfer.files].forEach((file, i) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.
dc/acrobat/blocks/acom-widget/acom-widget.js
Line 129 in b49ee54
shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging'); |
resolves: MWPW-157717