Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sending analytics for scenario where multiple files are selected #787

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

saragajic11
Copy link
Collaborator

resolves: MWPW-157717

Copy link

aem-code-sync bot commented Sep 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.85%. Comparing base (db7032a) to head (b49ee54).

Files with missing lines Patch % Lines
acrobat/blocks/acom-widget/acom-widget.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #787      +/-   ##
==========================================
- Coverage   85.89%   85.85%   -0.04%     
==========================================
  Files          42       42              
  Lines        5458     5459       +1     
==========================================
- Hits         4688     4687       -1     
- Misses        770      772       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 106. Maximum allowed is 100.

// console.log('Blob Viewer URL:', `<a href="${blobViewerUrl}" target="_blank">View PDF</a>`);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'file' is defined but never used.

[...ev.dataTransfer.files].forEach((file, i) => {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'i' is defined but never used.

[...ev.dataTransfer.files].forEach((file, i) => {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.

shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging');

@Blainegunn Blainegunn added this to the 0.2437 milestone Sep 5, 2024
@Blainegunn Blainegunn merged commit 27f2577 into stage Sep 5, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants