New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DC MILO 2431.1 #735

Merged

Blainegunn merged 2 commits into main from stage

Jul 30, 2024

Collaborator

Blainegunn commented Jul 30, 2024

No description provided.

Blainegunn added 2 commits

July 30, 2024 15:35


           MWPW-155520

81a0595


          Merge pull request #734 from adobecom/MWPW-155520

620e005

 MWPW-155520

aem-code-sync bot commented Jul 30, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

620e005 ✅ (latest)
81a0595 ✅

Blainegunn merged commit 92a91f4 into main

8 of 12 checks passed

github-actions bot reviewed

View reviewed changes

acrobat/scripts/alloy/mobile-widget-shown.js

-                  window?._satellite?.track('event', event);
+                // Alloy Ready...
+                const AlloyReady = setInterval(() => {
+                  if (window?._satellite?.track) {

Contributor

github-actions bot Jul 30, 2024

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_satellite'.

acrobat/scripts/alloy/mobile-widget-shown.js

+                const AlloyReady = setInterval(() => {
+                  if (window?._satellite?.track) {
+                    clearInterval(AlloyReady);
+                    window?._satellite?.track('event', event);

Contributor

github-actions bot Jul 30, 2024

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_satellite'.

github-actions bot reviewed

View reviewed changes

acrobat/scripts/alloy/mobile-widget-shown.js

Contributor

github-actions bot Jul 30, 2024

🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
URLSearchParams is not supported in op_mini all

dc/acrobat/scripts/alloy/mobile-widget-shown.js

Line 1 in 620e005

const params = new Proxy(new URLSearchParams(window.location.search),{

github-actions bot reviewed

View reviewed changes

acrobat/scripts/alloy/mobile-widget-shown.js

Contributor

github-actions bot Jul 30, 2024

🚫 [eslint] <comma-spacing> _{reported by reviewdog 🐶}
A space is required after ','.

dc/acrobat/scripts/alloy/mobile-widget-shown.js

Line 1 in 620e005

const params = new Proxy(new URLSearchParams(window.location.search),{

github-actions bot reviewed

View reviewed changes

acrobat/scripts/alloy/mobile-widget-shown.js

Contributor

github-actions bot Jul 30, 2024

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break after this opening brace.

dc/acrobat/scripts/alloy/mobile-widget-shown.js

Line 1 in 620e005

const params = new Proxy(new URLSearchParams(window.location.search),{

github-actions bot reviewed

View reviewed changes

acrobat/scripts/alloy/mobile-widget-shown.js

Contributor

github-actions bot Jul 30, 2024

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break before this closing brace.

dc/acrobat/scripts/alloy/mobile-widget-shown.js

Line 3 in 620e005

});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet