DC MILO 0.2337 #374
DC MILO 0.2337 #374
Conversation
…ining MWPW-135029 - fixed exception 'chrome is not defined'
MWPW-134643 Jarvis Chat
MWPW-129470: Added GitHub Action for js and css lint
Mwpw 136010
MWPW-136159 Update eslintrc.js as per Milo
MWPW-123236 DC App Banner for mobile/tablet devices
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
test/e2e/frictionless/page-objects/dcgnav.page.js|49 col 4| Trailing spaces not allowed.
test/e2e/frictionless/page-objects/frictionless.page.js|1 col 1| 'polytype' should be listed in the project's dependencies. Run 'npm i -S polytype' to add it
test/e2e/frictionless/page-objects/frictionless.page.js|1 col 25| Strings must use singlequote.
test/e2e/frictionless/page-objects/frictionless.page.js|2 col 28| Missing file extension "js" for "./dcgnav.page"
test/e2e/frictionless/page-objects/frictionless.page.js|2 col 28| Strings must use singlequote.
test/e2e/frictionless/page-objects/frictionless.page.js|3 col 34| Missing file extension "js" for "./pdfwidget.section"
test/e2e/frictionless/page-objects/frictionless.page.js|3 col 34| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|19 col 37| Missing file extension "js" for "../page-objects/extractpdfpages.page"
test/e2e/frictionless/step-definitions/dc.steps.js|19 col 37| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|20 col 31| Missing file extension "js" for "../page-objects/pdfeditor.page"
test/e2e/frictionless/step-definitions/dc.steps.js|20 col 31| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|21 col 30| Missing file extension "js" for "../page-objects/mergepdf.page"
test/e2e/frictionless/step-definitions/dc.steps.js|21 col 30| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|22 col 33| Missing file extension "js" for "../page-objects/compresspdf.page"
test/e2e/frictionless/step-definitions/dc.steps.js|22 col 33| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|23 col 34| Missing file extension "js" for "../page-objects/frictionless.page"
test/e2e/frictionless/step-definitions/dc.steps.js|23 col 34| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|24 col 26| Missing file extension "js" for "../support/cardinal"
test/e2e/frictionless/step-definitions/dc.steps.js|24 col 26| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|25 col 1| '@playwright/test' should be listed in the project's dependencies. Run 'npm i -S @playwright/test' to add it
test/e2e/frictionless/step-definitions/dc.steps.js|25 col 1| Expected 1 empty line after import statement not followed by another import.
test/e2e/frictionless/step-definitions/dc.steps.js|25 col 1| @playwright/test import should occur before import of ../page-objects/pdftoppt.page
test/e2e/frictionless/step-definitions/dc.steps.js|25 col 24| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|26 col 22| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|27 col 7| 'fs' is assigned a value but never used.
test/e2e/frictionless/step-definitions/dc.steps.js|27 col 20| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|66 col 5| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|67 col 5| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|68 col 5| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|69 col 5| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|71 col 19| A constructor name should not start with a lowercase letter.
test/e2e/frictionless/step-definitions/dc.steps.js|82 col 5| Expected no linebreak before this expression.
test/e2e/frictionless/step-definitions/dc.steps.js|82 col 48| Missing trailing comma.
test/e2e/frictionless/step-definitions/dc.steps.js|83 col 3| Unexpected newline before ')'.
test/e2e/frictionless/step-definitions/dc.steps.js|94 col 7| Unary operator '--' used.
test/e2e/frictionless/step-definitions/dc.steps.js|99 col 62| Unexpected unnamed async function.
test/e2e/frictionless/step-definitions/dc.steps.js|103 col 57| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|112 col 15| Unexpected string concatenation.
test/e2e/frictionless/step-definitions/dc.steps.js|112 col 15| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|114 col 7| 'convertedName' is never reassigned. Use 'const' instead.
test/e2e/frictionless/step-definitions/dc.steps.js|114 col 67| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|116 col 7| 'saveAsName' is never reassigned. Use 'const' instead.
test/e2e/frictionless/step-definitions/dc.steps.js|117 col 5| Unexpected require().
test/e2e/frictionless/step-definitions/dc.steps.js|117 col 13| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|118 col 5| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|252 col 41| Unexpected unnamed async function.
test/e2e/frictionless/step-definitions/dc.steps.js|256 col 76| Unexpected unnamed async function.
test/e2e/frictionless/step-definitions/dc.steps.js|258 col 43| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|258 col 54| Strings must use singlequote.
test/e2e/frictionless/step-definitions/dc.steps.js|260 col 12| 'item' is never reassigned. Use 'const' instead.
test/e2e/frictionless/step-definitions/dc.steps.js|264 col 42| A space is required after '{'.
test/e2e/frictionless/step-definitions/dc.steps.js|264 col 72| A space is required before '}'.
test/e2e/frictionless/step-definitions/dc.steps.js|270 col 40| Unnecessary escape character: ".
test/e2e/frictionless/step-definitions/dc.steps.js|270 col 58| Unexpected unnamed async function.
test/e2e/frictionless/step-definitions/dc.steps.js|278 col 56| Unnecessary escape character: ".
test/e2e/frictionless/step-definitions/dc.steps.js|278 col 75| Unexpected unnamed async function.
test/e2e/frictionless/step-definitions/dc.steps.js|279 col 34| Trailing spaces not allowed.
test/e2e/frictionless/step-definitions/dc.steps.js|284 col 50| Unexpected unnamed async function.
test/e2e/frictionless/step-definitions/dc.steps.js|286 col 27| Missing semicolon.
test/e2e/frictionless/step-definitions/dc.steps.js|289 col 82| Unexpected unnamed async function.
test/e2e/frictionless/step-definitions/dc.steps.js|291 col 27| Promise.all() is not supported in op_mini all
test/e2e/frictionless/step-definitions/dc.steps.js|292 col 5| 'PW' is not defined.
test/e2e/frictionless/step-definitions/dc.steps.js|293 col 29| Missing trailing comma.
test/e2e/frictionless/step-definitions/dc.steps.js|296 col 30| Trailing spaces not allowed.
test/e2e/frictionless/step-definitions/dc.steps.js|300 col 51| Unnecessary escape character: ".
test/e2e/frictionless/step-definitions/dc.steps.js|301 col 3| Unexpected unnamed async function.
test/e2e/frictionless/step-definitions/dc.steps.js|303 col 71| A space is required after '{'.
test/e2e/frictionless/step-definitions/dc.steps.js|303 col 86| A space is required before '}'.
test/e2e/frictionless/step-definitions/dc.steps.js|304 col 4| Missing trailing comma.
test/e2e/frictionless/step-definitions/dc.steps.js|307 col 21| Unexpected unnamed async function.
test/e2e/frictionless/step-definitions/dc.steps.js|309 col 4| Newline required at end of file but not found.
test/e2e/frictionless/support/cardinal.js|5 col 1| Prefer default export.
test/e2e/frictionless/support/cardinal.js|6 col 1| Expected indentation of 2 spaces but found 4.
test/e2e/frictionless/support/cardinal.js|7 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|8 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|9 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|10 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|11 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|12 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|13 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|14 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|15 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|16 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|17 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|18 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|19 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|20 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|21 col 1| Expected indentation of 4 spaces but found 6.
test/e2e/frictionless/support/cardinal.js|21 col 15| Missing trailing comma.
test/e2e/frictionless/support/cardinal.js|22 col 1| Expected indentation of 2 spaces but found 4.
test/e2e/frictionless/support/cardinal.js|23 col 1| Expected indentation of 0 spaces but found 2.
test/e2e/frictionless/support/cardinal.js|23 col 4| Newline required at end of file but not found.
| const skeletonLoader = new CustomEvent('DC_SkeletonShimmer:Ready'); | ||
| window.dispatchEvent(skeletonLoader); | ||
| }, 8000); | ||
|
|
||
| const localeMap = { | ||
| '': 'en-us', | ||
| 'br': 'pt-br', |
There was a problem hiding this comment.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'br' found.
| 'br': 'pt-br', | |
| br: 'pt-br', |
| @@ -214,7 +226,99 @@ | |||
| const isReturningUser = window.localStorage.getItem('pdfnow.auth'); | |||
| const isRedirection = /redirect_(?:conversion|files)=true/.test(window.location.search); | |||
| const preRenderDropZone = !isReturningUser && !isRedirection; | |||
| if (VERB === 'compress-pdf' || preRenderDropZone) { | |||
|
|
|||
| //Skeleton | |||
There was a problem hiding this comment.
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
| //Skeleton | |
| // Skeleton |
| @@ -214,7 +226,99 @@ | |||
| const isReturningUser = window.localStorage.getItem('pdfnow.auth'); | |||
| const isRedirection = /redirect_(?:conversion|files)=true/.test(window.location.search); | |||
| const preRenderDropZone = !isReturningUser && !isRedirection; | |||
| if (VERB === 'compress-pdf' || preRenderDropZone) { | |||
|
|
|||
| //Skeleton | |||
There was a problem hiding this comment.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
| //Skeleton | |
| //Skeleton |
| if (VERB === 'compress-pdf' || preRenderDropZone) { | ||
|
|
||
| //Skeleton | ||
| if (window.browser?.isMobile && !window.navigator.userAgent.includes('iPad') && location.pathname.includes('rearrange-pdf')) { |
There was a problem hiding this comment.
🚫 [eslint] <no-restricted-globals> reported by reviewdog 🐶
Unexpected use of 'location'.
|
|
||
|
|
There was a problem hiding this comment.
🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
More than 1 blank line not allowed.
| async selectFedsPopupItem(menu) { | ||
| const items = await this.fedsPopup.locator('a').all(); | ||
| if (typeof menu === 'number') { | ||
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5}}); |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5}}); | |
| await items[menu < 0 ? items.length + menu : menu].click({ position: {x: 5, y: 5}}); |
| async selectFedsPopupItem(menu) { | ||
| const items = await this.fedsPopup.locator('a').all(); | ||
| if (typeof menu === 'number') { | ||
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5}}); |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5}}); | |
| await items[menu < 0 ? items.length + menu : menu].click({position: { x: 5, y: 5}}); |
| async selectFedsPopupItem(menu) { | ||
| const items = await this.fedsPopup.locator('a').all(); | ||
| if (typeof menu === 'number') { | ||
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5}}); |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5}}); | |
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5 }}); |
| async selectFedsPopupItem(menu) { | ||
| const items = await this.fedsPopup.locator('a').all(); | ||
| if (typeof menu === 'number') { | ||
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5}}); |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5}}); | |
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5} }); |
| if (typeof menu === 'number') { | ||
| await items[menu < 0 ? items.length + menu : menu].click({position: {x: 5, y: 5}}); | ||
| } else if (typeof menu === 'string') { | ||
| const selected = items.filter(x => x.textContent.trim() === menu); |
There was a problem hiding this comment.
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
| const selected = items.filter(x => x.textContent.trim() === menu); | |
| const selected = items.filter((x) => x.textContent.trim() === menu); |
DC MILO 0.2337 Release