MWPW-123236 DC App Banner for mobile/tablet devices #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
Codecov Report
@@ Coverage Diff @@
## stage #365 +/- ##
==========================================
+ Coverage 89.63% 89.92% +0.28%
==========================================
Files 24 25 +1
Lines 2797 2927 +130
==========================================
+ Hits 2507 2632 +125
- Misses 290 295 +5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
zagi25
requested changes
Sep 6, 2023
|
|
|
|
The lint-ing errors related to unit tests are trivial, we may need to change the rules around unit test code. |
|
|
|
|
|
TsayAdobe
approved these changes
Sep 11, 2023
|
|
|
|
Blainegunn
approved these changes
Sep 11, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
https://jira.corp.adobe.com/browse/MWPW-123236
Before: (Empty page)
https://main--dc--puruadobe.hlx.live/drafts/doreswam/no-acrobat-banner
After: (Page only with app banner)
https://puru-mwpw-123236--dc--puruadobe.hlx.live/drafts/doreswam/scan-banner?martech=off
https://puru-mwpw-123236--dc--puruadobe.hlx.live/drafts/doreswam/acrobat-banner?martech=off