-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-160629] - Updated Homepage UI #47
Open
snowiewdev
wants to merge
14
commits into
main
Choose a base branch
from
redesign/home
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cle gradient based on hexcode
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
snowiewdev
changed the title
[Pending Jira ticket creation] - Updated Homepage UI
[MWPW-160629] - Updated Homepage UI
Oct 17, 2024
snowiewdev
requested review from
ryanmparrish,
rgclayton,
chrischrischris,
mokimo,
narcis-radu and
overmyheadandbody
October 17, 2024 20:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
Homepage
layout based on updated design in Figma. Updates include:Masonry
block withhero-masonry
variant locally to support new design in Figma specific to Blog repoEditorial Card
with minor css updates for selected topic sectionbanner
block to support new design in figmaArticle Grid
block to support fetching latest articles or custom selected articles, and displaying custom banner in desired positionTest Urls
section belowResolves
Test Urls
Home
Blocks
Hero Masonry
circle-gradient
insection-metadata
table with format like#hexcode1, #hexcode2
Banner
Article Grid
IntersectionObserver
is added to only load the block when it's scroll into view to reduce initial load time so it should not affect page load time, as seen by green lighthouse score on homepageQA Tracking Sheet: