[MWPW-150667] - milolibs query parameter not working #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overmyheadandbody
approved these changes
Jun 17, 2024
| @@ -19,7 +19,7 @@ export const [setLibs, getLibs] = (() => { | |||
| (prodLibs, location) => { | |||
| libs = (() => { | |||
| const { hostname, search } = location || window.location; | |||
| if (!(hostname.includes('.hlx.') || hostname.includes('local'))) return prodLibs; | |||
| if (!['.hlx.', '.stage.', 'local'].some((i) => hostname.includes(i))) return prodLibs; | |||
There was a problem hiding this comment.
Same question as another PR, is there a good reason for going with 'local' instead of 'localhost'? I can't think of hostnames that would have issues with this approach, but also can't think of a good reason to not be specific about it.
There was a problem hiding this comment.
No reason, I wanted to use the same string as was used in the former version
JasonHowellSlavin
approved these changes
Jun 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR extends the nonprod hostnames check that determines if the milolibs query parameter is allowed.
Resolves:
https://jira.corp.adobe.com/browse/MWPW-150667
Test URLs: