Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-144683 Remove Null from Article Header #37

Closed
wants to merge 2 commits into from
Closed

MWPW-144683 Remove Null from Article Header #37

wants to merge 2 commits into from

Conversation

meganthecoder
Copy link
Contributor

  • Make sure "null" won't show in the article header eyebrow if there's no category on the page

Resolves: MWPW-144683

Test URLs:

@meganthecoder meganthecoder added bug Something isn't working needs-verification labels Mar 20, 2024
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 20, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 20, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/methomas/no-category?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

JasonHowellSlavin
JasonHowellSlavin approved these changes Mar 21, 2024
View reviewed changes
test/scripts/mocks/blocks/article-feed/article-helpers.js

export function getTaxonomyModule() {
return true;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this here to prevent errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are here as mocks for the external milo scripts, as called out as best practice by the community. Before, I've tried to use import maps like we do in milo tests, but they don't work with template strings in dynamic imports. Here, I'm mocking the external scripts by setting milo libs to pull from the localhost mocks folder.

@meganthecoder meganthecoder mentioned this pull request Mar 27, 2024
Merged
@meganthecoder meganthecoder mentioned this pull request Apr 10, 2024
Merged
@meganthecoder
Copy link
Contributor Author

I'm closing this PR because the functionality is no longer needed, and I've opened a new one with just the unit test updates. #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonHowellSlavin JasonHowellSlavin JasonHowellSlavin approved these changes

@Brandon32 Brandon32 Brandon32 approved these changes

Assignees

@Dli3 Dli3

Labels
bug Something isn't working needs-verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meganthecoder @Brandon32 @JasonHowellSlavin @Dli3