Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-142563: Add Eager Loading to LPC Image for Blog #36

Closed
wants to merge 7 commits into from

Conversation

JasonHowellSlavin
Copy link
Contributor

  • Adds loading: eager and fetchpriority: high to blog.

Context: There was never a large difference in the PSI scores when testing. However, I am hoping that this will get us more in line with Brand Blog and we will see CrUX scores benefit from the change.

Resolves: MWPW-142563

Test URLs:

Copy link

aem-code-sync bot commented Mar 1, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Mar 1, 2024

Page Scores Audits Google
/blog/basics/what-is-a-cms-and-how-does-it-work?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Comment on lines +121 to +122
lcpImg?.setAttribute('loading', 'eager');
lcpImg?.setAttribute('fetchpriority', 'high');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the default is already eager.
adobecom/milo#1908 (comment)

The difference you are going to see with fetchpriority is if there are multiple eager loading images.

high
Fetch the image at a high priority relative to other images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants