Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-135908 Add lana #29

Merged
merged 2 commits into from
Nov 16, 2023
Merged

MWPW-135908 Add lana #29

merged 2 commits into from
Nov 16, 2023

Conversation

meganthecoder
Copy link
Contributor

@meganthecoder meganthecoder commented Nov 15, 2023

Copy link

aem-code-sync bot commented Nov 15, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@amauch-adobe
Copy link

@meganthecoder, quick question do you know what you plan on using for tags on your messages? It is best practice to send in at least one tag for each message, that way we can filter messages for certain tags when creating alerts. You can see some ideas for tags here: https://wiki.corp.adobe.com/pages/viewpage.action?pageId=3008810368

Also, all LANA messages shouldn't be sent in with empty/null tags. Most teams have chosen to have a default tag sent in if no tag is provided.

@meganthecoder
Copy link
Contributor Author

@meganthecoder, quick question do you know what you plan on using for tags on your messages? It is best practice to send in at least one tag for each message, that way we can filter messages for certain tags when creating alerts. You can see some ideas for tags here: https://wiki.corp.adobe.com/pages/viewpage.action?pageId=3008810368

Also, all LANA messages shouldn't be sent in with empty/null tags. Most teams have chosen to have a default tag sent in if no tag is provided.

@amauch-adobe I update the code. Does that look right?

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34f33d1) 86.36% compared to head (eae7691) 91.42%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   86.36%   91.42%   +5.06%     
==========================================
  Files           2        2              
  Lines         176      175       -1     
==========================================
+ Hits          152      160       +8     
+ Misses         24       15       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amauch-adobe
Copy link

@meganthecoder, quick question do you know what you plan on using for tags on your messages? It is best practice to send in at least one tag for each message, that way we can filter messages for certain tags when creating alerts. You can see some ideas for tags here: https://wiki.corp.adobe.com/pages/viewpage.action?pageId=3008810368
Also, all LANA messages shouldn't be sent in with empty/null tags. Most teams have chosen to have a default tag sent in if no tag is provided.

@amauch-adobe I update the code. Does that look right?

yeah, that works.

Copy link

aem-code-sync bot commented Nov 16, 2023

Page Scores Audits Google
/blog/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@meganthecoder meganthecoder merged commit 977a792 into main Nov 16, 2023
7 of 8 checks passed
@meganthecoder meganthecoder deleted the methomas/lana branch November 16, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants