-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-135908 Add lana #29
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
@meganthecoder, quick question do you know what you plan on using for tags on your messages? It is best practice to send in at least one tag for each message, that way we can filter messages for certain tags when creating alerts. You can see some ideas for tags here: https://wiki.corp.adobe.com/pages/viewpage.action?pageId=3008810368 Also, all LANA messages shouldn't be sent in with empty/null tags. Most teams have chosen to have a default tag sent in if no tag is provided. |
@amauch-adobe I update the code. Does that look right? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 86.36% 91.42% +5.06%
==========================================
Files 2 2
Lines 176 175 -1
==========================================
+ Hits 152 160 +8
+ Misses 24 15 -9 ☔ View full report in Codecov by Sentry. |
yeah, that works. |
|
Resolves: MWPW-135908
Test URLs: