Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-138748 Moving Folders to avoid Namespace Collision #25

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

JasonHowellSlavin
Copy link
Contributor

Copy link

aem-code-sync bot commented Nov 7, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Nov 7, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Brandon32
Copy link
Contributor

@JasonHowellSlavin Need to update scripts.js
const STYLES = '/bacom-blog/styles/styles.css';

Copy link

aem-code-sync bot commented Nov 7, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #25 (c7e3024) into main (f36cbce) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files           2        2           
  Lines         176      176           
=======================================
  Hits          152      152           
  Misses         24       24           
Files Coverage Δ
bacom-blog/blocks/language-menu/language-menu.js 100.00% <ø> (ø)
bacom-blog/scripts/utils.js 83.44% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

aem-code-sync bot commented Nov 7, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 7, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JasonHowellSlavin JasonHowellSlavin merged commit 82acdcc into main Nov 7, 2023
6 checks passed
@JasonHowellSlavin JasonHowellSlavin deleted the modify-scripts-location branch November 7, 2023 20:01
JasonHowellSlavin added a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants