New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-135727: CSS for Quotes, Columns #23

Merged

JasonHowellSlavin merged 5 commits into main from quote-and-spot-check

Nov 7, 2023

Contributor

JasonHowellSlavin commented Nov 2, 2023 •

edited

Loading

Adds CSS for quote, columns, and article feed cards

Resolves: MWPW-135727

Test URLs:


          Adding CSS styles for columns, quote, and spot checked pages. Not res…

63ae879

…tricting banner widths

JasonHowellSlavin requested review from Brandon32 and meganthecoder

November 2, 2023 21:03

aem-code-sync bot commented Nov 2, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-run PSI Checks

aem-code-sync bot commented Nov 2, 2023

Page	Scores	Audits	Google
/drafts/staged-content/blog/basics/digital-marketing
/jp/drafts/staged-content/blog/basics/recommendation-engine?martech=off

meganthecoder approved these changes

View reviewed changes


          Adding some styles based on comment by Dennis regarding text cut off

6526c9f

Brandon32 approved these changes

View reviewed changes

Contributor

Brandon32 left a comment

Feature is missing in description and ticket link is broken, also martech=off is missing for digital-marketing

codecov-commenter commented Nov 3, 2023 •

edited

Loading

Codecov Report

Merging #23 (c73b1c5) into main (69eb1c0) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files           2        2           
  Lines         176      176           
=======================================
  Hits          152      152           
  Misses         24       24

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

aem-code-sync bot commented Nov 6, 2023

Page	Scores	Audits	Google
/drafts/staged-content/blog/basics/digital-marketing
/jp/drafts/staged-content/blog/basics/recommendation-engine?martech=off


          Additional cutoff issues

b6e28da

aem-code-sync bot commented Nov 6, 2023

Page	Scores	Audits	Google
/drafts/staged-content/blog/basics/digital-marketing?martech=off
/jp/drafts/staged-content/blog/basics/recommendation-engine?martech=off

JasonHowellSlavin added 2 commits

November 6, 2023 16:06


          Additional QA for mobile devices

554284b


          Additional QA for mobile devices, checking for desktop

c73b1c5

aem-code-sync bot commented Nov 7, 2023

Page	Scores	Audits	Google
/drafts/staged-content/blog/basics/digital-marketing?martech=off
/jp/drafts/staged-content/blog/basics/recommendation-engine?martech=off

Dli3 added the verified label

JasonHowellSlavin merged commit 7c678be into main

6 of 7 checks passed

JasonHowellSlavin deleted the quote-and-spot-check branch

November 7, 2023 00:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels