Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding prod domains to config #21

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Adding prod domains to config #21

merged 1 commit into from
Oct 18, 2023

Conversation

JasonHowellSlavin
Copy link
Contributor

  • Adds prodDomains to config. localizeLink utilizes it in its checks to see if it needs to localize or not. Currently some executions of the script return undefined which may interfere with the function.

N/A

Test URLs:
N/A

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 18, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@Brandon32
Copy link
Contributor

@JasonHowellSlavin Do we need to worry about non-blog prod domain URLs being localized?

@JasonHowellSlavin
Copy link
Contributor Author

@JasonHowellSlavin Do we need to worry about non-blog prod domain URLs being localized?

100%.
I think that will always be a problem, but it is one we can't test right now because prodDomains is missing.

What is happening now is a link to something using the full link like https://business.adobe.com/blog/basics/3-reasons-marketers-are-talking-about-real-time-cdp when observed from de preview pages is not currently getting localized to de because the check for whether the link is relative checks against hostname. Really all adding the prodDomains is doing at this point is ensuring that links that would get localized once we push the code live also get localized in preview modes.

@JasonHowellSlavin JasonHowellSlavin merged commit 5ffb008 into main Oct 18, 2023
5 of 6 checks passed
@JasonHowellSlavin JasonHowellSlavin deleted the add-prod-domains branch October 18, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants