MWPW-136993 Add sitemap and query index #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon32
added
the
trivial
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 86.36% 86.36%
=======================================
Files 2 2
Lines 176 176
=======================================
Hits 152 152
Misses 24 24 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
meganthecoder
requested changes
Oct 4, 2023
helix-query.yaml
Outdated
Comment on lines
7
to
14
| - '/blog/actualites/**' | ||
| - '/blog/basics/**' | ||
| - '/blog/fragments/**' | ||
| - '/blog/grundlagen/**' | ||
| - '/blog/how-to/**' | ||
| - '/blog/neues/**' | ||
| - '/blog/perspectives/**' | ||
| - '/blog/perspektiven/**' |
There was a problem hiding this comment.
Why are there French and German folder names included in the US index?
helix-query.yaml
Outdated
| - '/blog/' | ||
| - '/blog/actualites/**' | ||
| - '/blog/basics/**' | ||
| - '/blog/fragments/**' |
There was a problem hiding this comment.
Don't we want to exclude fragments?
helix-query.yaml
Outdated
Comment on lines
152
to
165
| blog-jp: | ||
| include: | ||
| - '/uk/blog/' | ||
| - '/uk/blog/actualites/**' | ||
| - '/uk/blog/basics/**' | ||
| - '/uk/blog/fragments/**' | ||
| - '/uk/blog/grundlagen/**' | ||
| - '/uk/blog/how-to/**' | ||
| - '/uk/blog/neues/**' | ||
| - '/uk/blog/perspectives/**' | ||
| - '/uk/blog/perspektiven/**' | ||
| - '/uk/blog/the-latest/**' | ||
| - '/uk/blog/topic/**' | ||
| - '/uk/blog/trends/**' |
There was a problem hiding this comment.
Looks like these should be /jp/blog/
meganthecoder
approved these changes
Oct 6, 2023
JasonHowellSlavin
approved these changes
Oct 9, 2023
Brandon32
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-136993
Test URLs: