Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-135320 Init article header #16

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Conversation

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 13, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 13, 2023

@meganthecoder
Copy link
Contributor Author

FYI I tried writing tests but couldn’t mock the dynamic import. Have a question out to Okan, and I'll create a ticket to write tests if he comes back with anything actionable

scripts/utils.js Outdated Show resolved Hide resolved
scripts/utils.js Outdated Show resolved Hide resolved
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 18, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 20, 2023

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #16 (a17e697) into main (3fb4caa) will decrease coverage by 12.11%.
The diff coverage is 53.33%.

@@             Coverage Diff             @@
##             main      #16       +/-   ##
===========================================
- Coverage   98.47%   86.36%   -12.11%     
===========================================
  Files           2        2               
  Lines         131      176       +45     
===========================================
+ Hits          129      152       +23     
- Misses          2       24       +22     
Files Changed Coverage Δ
scripts/utils.js 83.44% <53.33%> (-14.56%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 21, 2023

@Dli3 Dli3 added the verified It's been E2E tested label Sep 22, 2023
@meganthecoder meganthecoder merged commit 2fad9b0 into main Sep 22, 2023
6 of 7 checks passed
@meganthecoder meganthecoder deleted the methomas/article-header branch September 22, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified It's been E2E tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants