Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-135319 Init Tags Block #15

Merged
merged 5 commits into from
Sep 13, 2023
Merged

MWPW-135319 Init Tags Block #15

merged 5 commits into from
Sep 13, 2023

Conversation

meganthecoder
Copy link
Contributor

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 6, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 6, 2023

Page Scores Audits Google
/blog/perspectives/transforming-the-citizen-digital-experience-with-content-velo
city-and-generative-ai?martech=off		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 6, 2023

Page Scores Audits Google
/blog/perspectives/transforming-the-citizen-digital-experience-with-content-velo
city-and-generative-ai?martech=off		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #15 (b8ed2e9) into main (2c20931) will decrease coverage by 1.53%.
The diff coverage is 96.87%.

@@             Coverage Diff             @@
##              main      #15      +/-   ##
===========================================
- Coverage   100.00%   98.47%   -1.53%     
===========================================
  Files            2        2              
  Lines           67      131      +64     
===========================================
+ Hits            67      129      +62     
- Misses           0        2       +2
Files Changed Coverage Δ
scripts/utils.js 98.00% <96.87%> (-2.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JasonHowellSlavin
JasonHowellSlavin reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@JasonHowellSlavin JasonHowellSlavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

scripts/utils.js Show resolved Hide resolved
scripts/utils.js Show resolved Hide resolved
test/scripts/mocks/tagsWithRecBody.html Outdated Show resolved Hide resolved
Brandon32
Brandon32 reviewed Sep 6, 2023
View reviewed changes
scripts/utils.js Outdated
}

function buildTagsBlock() {
const tagsArray = [...document.head.querySelectorAll('meta[property="article:tag"]')].map((el) => el.content) || [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be an early return since we are before loadArea, or do we want an empty tag block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that's a good idea. Updated

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 7, 2023

Page Scores Audits Google
/blog/perspectives/transforming-the-citizen-digital-experience-with-content-velo
city-and-generative-ai?martech=off		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

JasonHowellSlavin
JasonHowellSlavin approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@JasonHowellSlavin JasonHowellSlavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to make to a ticket for the code smell. Will we ever get to it I am not sure, but good to have stuff like that in our backlog if we ever get some extra time.

@meganthecoder
Copy link
Contributor Author

Might be good to make to a ticket for the code smell. Will we ever get to it I am not sure, but good to have stuff like that in our backlog if we ever get some extra time.

Sure! https://jira.corp.adobe.com/browse/MWPW-136146

@meganthecoder meganthecoder added the verified It's been E2E tested label Sep 13, 2023
@meganthecoder meganthecoder merged commit 3fb4caa into main Sep 13, 2023
6 of 7 checks passed
@meganthecoder meganthecoder deleted the methomas/tags branch September 13, 2023 17:36
@meganthecoder meganthecoder mentioned this pull request Dec 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brandon32 Brandon32 Brandon32 approved these changes

@JasonHowellSlavin JasonHowellSlavin JasonHowellSlavin approved these changes

Assignees

@Dli3 Dli3

Labels
verified It's been E2E tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meganthecoder @codecov-commenter @Brandon32 @JasonHowellSlavin @Dli3