Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-135074] CSS Matching Consumer Repo #12

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

JasonHowellSlavin
Copy link
Contributor

Adding base CSS styles. Need other work to be done before finishing touches

  • Added very basic CSS styles for width, vars, etc.
  • Identified other work that needed to be done for parity.

Note: There will be another CSS ticket. Styles are coming with blocks that are not 1:1, as well as some other issues, like autoblocks etc. We are likely better off doing CSS parity comparisons when we have all the blocks updated and the code blocks in place.

At this point in time, the only thing worth verifying is the content width.

Resolves: MWPW-135074

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 28, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 28, 2023

Page Scores Audits Google
/blog/basics/business-case?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JasonHowellSlavin JasonHowellSlavin merged commit e9e94ae into main Aug 30, 2023
3 checks passed
@JasonHowellSlavin JasonHowellSlavin deleted the base-css-styles branch August 30, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants