MWPW-134706 Reevaluate bacom-blog repo #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon32
requested review from
auniverseaway,
JasonHowellSlavin and
meganthecoder
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
Brandon32
force-pushed
the
bmarshal/reeveluate-blog
branch
from
1377b78
to
794d169
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 2 +1
Lines 31 67 +36
=========================================
+ Hits 31 67 +36
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment was marked as outdated.
This comment was marked as outdated.
|
meganthecoder
approved these changes
Aug 9, 2023
JasonHowellSlavin
approved these changes
Aug 9, 2023
Comment on lines
+1
to
+79
| /* eslint-disable import/no-extraneous-dependencies */ | ||
| import { importMapsPlugin } from '@web/dev-server-import-maps'; | ||
| import { defaultReporter } from '@web/test-runner'; | ||
|
|
||
| function customReporter() { | ||
| return { | ||
| async reportTestFileResults({ logger, sessionsForTestFile }) { | ||
| sessionsForTestFile.forEach((session) => { | ||
| session.testResults.tests.forEach((test) => { | ||
| if (!test.passed && !test.skipped) { | ||
| logger.log(test); | ||
| } | ||
| }); | ||
| }); | ||
| }, | ||
| }; | ||
| } | ||
| export default { | ||
| coverageConfig: { | ||
| exclude: [ | ||
| '**/mocks/**', | ||
| '**/node_modules/**', | ||
| '**/test/**', | ||
| '**/deps/**', | ||
| ], | ||
| }, | ||
| plugins: [importMapsPlugin({})], | ||
| reporters: [ | ||
| defaultReporter({ reportTestResults: true, reportTestProgress: true }), | ||
| customReporter(), | ||
| ], | ||
| testRunnerHtml: (testFramework) => ` | ||
| <html> | ||
| <head> | ||
| <script type='module'> | ||
| const oldFetch = window.fetch; | ||
| window.fetch = async (resource, options) => { | ||
| if (!resource.startsWith('/') && !resource.startsWith('http://localhost')) { | ||
| console.error( | ||
| '** fetch request for an external resource is disallowed in unit tests, please find a way to mock! https://github.com/orgs/adobecom/discussions/814#discussioncomment-6060759 provides guidance on how to fix the issue.', | ||
| resource | ||
| ); | ||
| } | ||
| return oldFetch.call(window, resource, options); | ||
| }; | ||
|
|
||
| const oldXHROpen = XMLHttpRequest.prototype.open; | ||
| XMLHttpRequest.prototype.open = async function (...args) { | ||
| let [method, url, asyn] = args; | ||
| if (!resource.startsWith('/') && url.startsWith('http://localhost')) { | ||
| console.error( | ||
| '** XMLHttpRequest request for an external resource is disallowed in unit tests, please find a way to mock! https://github.com/orgs/adobecom/discussions/814#discussioncomment-6060759 provides guidance on how to fix the issue.', | ||
| url | ||
| ); | ||
| } | ||
| return oldXHROpen.apply(this, args); | ||
| }; | ||
| const observer = new MutationObserver((mutationsList, observer) => { | ||
| for(let mutation of mutationsList) { | ||
| if (mutation.type === 'childList') { | ||
| for(let node of mutation.addedNodes) { | ||
| if(node.nodeName === 'SCRIPT' && node.src && !node.src.startsWith('http://localhost')) { | ||
| console.error( | ||
| '** An external 3rd script has been added. This is disallowed in unit tests, please find a way to mock! https://github.com/orgs/adobecom/discussions/814#discussioncomment-6060891 provides guidance on how to fix the issue.', | ||
| node.src | ||
| ); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }); | ||
| observer.observe(document.head, { childList: true }); | ||
| </script> | ||
| </head> | ||
| <body> | ||
| <script type='module' src='${testFramework}'></script> | ||
| </body> | ||
| </html>`, | ||
| }; |
There was a problem hiding this comment.
this file has the mjs extension in milo, why change it here?
There was a problem hiding this comment.
To match milo-college, it is using "type": "module" in package.json so mjs is redundant.
@meganthecoder To match milo consumers, I using milo-college to see what changed: adobecom/milo-college@53743b7...main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-134706
Test URLs: