Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Add run_config to ClientApp Context #3751

Merged
merged 39 commits into from
Jul 11, 2024
Merged

feat(framework) Add run_config to ClientApp Context #3751

merged 39 commits into from
Jul 11, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@charlesbvll charlesbvll changed the title feat(framework:skip) Add override to context and utility funcion feat(framework:skip) Add run_config to ClientApp Context Jul 8, 2024
@charlesbvll charlesbvll marked this pull request as ready for review July 8, 2024 16:24
@charlesbvll charlesbvll changed the title feat(framework:skip) Add run_config to ClientApp Context feat(framework) Add run_config to ClientApp Context Jul 8, 2024
danieljanes
danieljanes previously approved these changes Jul 11, 2024
View reviewed changes
@danieljanes danieljanes enabled auto-merge (squash) July 11, 2024 14:41
@danieljanes danieljanes merged commit 2f2e346 into main Jul 11, 2024
28 checks passed
@danieljanes danieljanes deleted the add-override-clientapp branch July 11, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charlesbvll @danieljanes